Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 216513004: Files.app: Add a test to create new folder. (Closed)

Created:
6 years, 9 months ago by hirono
Modified:
6 years, 8 months ago
Reviewers:
yoshiki, hirono1
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Files.app: Add a test to create new folder. BUG=345048 TEST=run the new test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260444

Patch Set 1 #

Patch Set 2 : Fixed. #

Patch Set 3 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -4 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/resources/file_manager/foreground/js/file_manager.js View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_manager_browsertest/keyboard_operations.js View 1 2 2 chunks +64 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
hirono
PTAL the CL? Thanks!
6 years, 9 months ago (2014-03-28 08:01:41 UTC) #1
yoshiki
lgtm
6 years, 9 months ago (2014-03-28 08:08:15 UTC) #2
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 9 months ago (2014-03-28 08:09:44 UTC) #3
hirono
On 2014/03/28 08:09:44, hirono wrote: > The CQ bit was checked by mailto:hirono@chromium.org Thanks!
6 years, 9 months ago (2014-03-28 08:10:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/216513004/40001
6 years, 9 months ago (2014-03-28 08:10:32 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 13:06:10 UTC) #6
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) base_unittests, net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=137216
6 years, 9 months ago (2014-03-28 13:06:11 UTC) #7
hirono1
The CQ bit was checked by hirono@google.com
6 years, 8 months ago (2014-03-30 02:23:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/216513004/40001
6 years, 8 months ago (2014-03-30 02:23:10 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-03-30 17:21:50 UTC) #10
Message was sent while issue was closed. 
Change committed as 260444

Powered by Google App Engine
This is Rietveld 408576698