Issue 216513003: Adjust various constants for x32 port

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 216513003: Adjust various constants for x32 port (Closed)

Created:
6 years, 8 months ago by haitao.feng

Modified:
6 years, 8 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -9 lines)			Patch
M	src/x64/assembler-x64-inl.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/x64/code-stubs-x64.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

Toon Verwaest

I think we should introduce a macro-assembler instruction here to avoid all that branching. Can ...

6 years, 8 months ago (2014-03-28 10:25:30 UTC) #2

haitao.feng

Toon, thanks for the review. I split this CL to include constant adjustment for x32 ...

6 years, 8 months ago (2014-03-31 12:03:19 UTC) #3

haitao.feng

6 years, 8 months ago (2014-04-02 02:35:07 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r20420 (presubmit successful).