Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1455)

Unified Diff: chrome/browser/extensions/extension_renderer_state.cc

Issue 216513002: Replace DCHECK(BrowserThread::CurrentlyOn) with DCHECK_CURRENTLY_ON in extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_renderer_state.cc
diff --git a/chrome/browser/extensions/extension_renderer_state.cc b/chrome/browser/extensions/extension_renderer_state.cc
index bb3621a5ada472a8f7ecc2fd64098d82c26795c8..341db2788cc789e4cbde81f2b1df20f39716a7b5 100644
--- a/chrome/browser/extensions/extension_renderer_state.cc
+++ b/chrome/browser/extensions/extension_renderer_state.cc
@@ -81,7 +81,7 @@ class ExtensionRendererState::TabObserver
};
ExtensionRendererState::TabObserver::TabObserver() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
registrar_.Add(this,
content::NOTIFICATION_WEB_CONTENTS_RENDER_VIEW_HOST_CREATED,
content::NotificationService::AllBrowserContextsAndSources());
@@ -92,7 +92,7 @@ ExtensionRendererState::TabObserver::TabObserver() {
}
ExtensionRendererState::TabObserver::~TabObserver() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
}
void ExtensionRendererState::TabObserver::Observe(
@@ -189,21 +189,21 @@ void ExtensionRendererState::Shutdown() {
void ExtensionRendererState::SetTabAndWindowId(
int render_process_host_id, int routing_id, int tab_id, int window_id) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
RenderId render_id(render_process_host_id, routing_id);
map_[render_id] = TabAndWindowId(tab_id, window_id);
}
void ExtensionRendererState::ClearTabAndWindowId(
int render_process_host_id, int routing_id) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
RenderId render_id(render_process_host_id, routing_id);
map_.erase(render_id);
}
bool ExtensionRendererState::GetTabAndWindowId(
const content::ResourceRequestInfo* info, int* tab_id, int* window_id) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
int render_process_id;
if (info->GetProcessType() == content::PROCESS_TYPE_PLUGIN) {
render_process_id = info->GetOriginPID();
@@ -222,7 +222,7 @@ bool ExtensionRendererState::GetTabAndWindowId(
}
bool ExtensionRendererState::IsWebViewRenderer(int render_process_id) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
for (WebViewInfoMap::iterator i = webview_info_map_.begin();
i != webview_info_map_.end(); ++i) {
if (i->first.first == render_process_id)
@@ -234,14 +234,14 @@ bool ExtensionRendererState::IsWebViewRenderer(int render_process_id) {
void ExtensionRendererState::AddWebView(int guest_process_id,
int guest_routing_id,
const WebViewInfo& webview_info) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
RenderId render_id(guest_process_id, guest_routing_id);
webview_info_map_[render_id] = webview_info;
}
void ExtensionRendererState::RemoveWebView(int guest_process_id,
int guest_routing_id) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
RenderId render_id(guest_process_id, guest_routing_id);
webview_info_map_.erase(render_id);
}
@@ -249,7 +249,7 @@ void ExtensionRendererState::RemoveWebView(int guest_process_id,
bool ExtensionRendererState::GetWebViewInfo(int guest_process_id,
int guest_routing_id,
WebViewInfo* webview_info) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
RenderId render_id(guest_process_id, guest_routing_id);
WebViewInfoMap::iterator iter = webview_info_map_.find(render_id);
if (iter != webview_info_map_.end()) {
« no previous file with comments | « chrome/browser/extensions/extension_messages_apitest.cc ('k') | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698