Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2398)

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 216513002: Replace DCHECK(BrowserThread::CurrentlyOn) with DCHECK_CURRENTLY_ON in extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/crx_installer.cc
diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc
index 09af4683b39fc793a1c226ab3e0a8223b27affb8..ad7c18de5b0ba261177f775ad2acd629a1469c0d 100644
--- a/chrome/browser/extensions/crx_installer.cc
+++ b/chrome/browser/extensions/crx_installer.cc
@@ -477,7 +477,7 @@ void CrxInstaller::OnUnpackSuccess(
}
void CrxInstaller::CheckImportsAndRequirements() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
ExtensionService* service = service_weak_.get();
if (!service || service->browser_terminating())
return;
@@ -506,7 +506,7 @@ void CrxInstaller::CheckImportsAndRequirements() {
void CrxInstaller::OnRequirementsChecked(
std::vector<std::string> requirement_errors) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
if (!service_weak_)
return;
@@ -526,7 +526,7 @@ void CrxInstaller::OnRequirementsChecked(
void CrxInstaller::OnBlacklistChecked(
extensions::BlacklistState blacklist_state) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
if (!service_weak_)
return;
@@ -553,7 +553,7 @@ void CrxInstaller::OnBlacklistChecked(
}
void CrxInstaller::ConfirmInstall() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
ExtensionService* service = service_weak_.get();
if (!service || service->browser_terminating())
return;
@@ -618,7 +618,7 @@ void CrxInstaller::ConfirmInstall() {
}
void CrxInstaller::InstallUIProceed() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
ExtensionService* service = service_weak_.get();
if (!service || service->browser_terminating())
@@ -730,7 +730,7 @@ void CrxInstaller::ReportFailureFromFileThread(const CrxInstallerError& error) {
}
void CrxInstaller::ReportFailureFromUIThread(const CrxInstallerError& error) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
content::NotificationService* service =
content::NotificationService::current();
@@ -774,7 +774,7 @@ void CrxInstaller::ReportSuccessFromFileThread() {
}
void CrxInstaller::ReportSuccessFromUIThread() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
if (!service_weak_.get() || service_weak_->browser_terminating())
return;
@@ -840,7 +840,7 @@ void CrxInstaller::CleanupTempFiles() {
}
void CrxInstaller::CheckUpdateFromSettingsPage() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
ExtensionService* service = service_weak_.get();
if (!service || service->browser_terminating())
@@ -861,7 +861,7 @@ void CrxInstaller::CheckUpdateFromSettingsPage() {
}
void CrxInstaller::ConfirmReEnable() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
ExtensionService* service = service_weak_.get();
if (!service || service->browser_terminating())
« no previous file with comments | « chrome/browser/extensions/browser_permissions_policy_delegate.cc ('k') | chrome/browser/extensions/data_deleter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698