Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1459)

Unified Diff: chrome/browser/extensions/api/cast_channel/cast_channel_api.cc

Issue 216513002: Replace DCHECK(BrowserThread::CurrentlyOn) with DCHECK_CURRENTLY_ON in extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/cast_channel/cast_channel_api.cc
diff --git a/chrome/browser/extensions/api/cast_channel/cast_channel_api.cc b/chrome/browser/extensions/api/cast_channel/cast_channel_api.cc
index b662a15e36bf3eb3f95378793bdd45578ec4780e..cd9b8ba59f8ab1b1e9f75c5f7db3067c17765075 100644
--- a/chrome/browser/extensions/api/cast_channel/cast_channel_api.cc
+++ b/chrome/browser/extensions/api/cast_channel/cast_channel_api.cc
@@ -79,7 +79,7 @@ void CastChannelAPI::SetSocketForTest(scoped_ptr<CastSocket> socket_for_test) {
void CastChannelAPI::OnError(const CastSocket* socket,
cast_channel::ChannelError error) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
ChannelInfo channel_info;
socket->FillChannelInfo(&channel_info);
channel_info.error_state = error;
@@ -92,7 +92,7 @@ void CastChannelAPI::OnError(const CastSocket* socket,
void CastChannelAPI::OnMessage(const CastSocket* socket,
const MessageInfo& message_info) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
ChannelInfo channel_info;
socket->FillChannelInfo(&channel_info);
scoped_ptr<base::ListValue> results =
@@ -132,7 +132,7 @@ CastSocket* CastChannelAsyncApiFunction::GetSocketOrCompleteWithError(
}
int CastChannelAsyncApiFunction::AddSocket(CastSocket* socket) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
DCHECK(socket);
DCHECK(manager_);
const int id = manager_->Add(socket);
@@ -141,7 +141,7 @@ int CastChannelAsyncApiFunction::AddSocket(CastSocket* socket) {
}
void CastChannelAsyncApiFunction::RemoveSocket(int channel_id) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
DCHECK(manager_);
manager_->Remove(extension_->id(), channel_id);
}
@@ -166,14 +166,14 @@ void CastChannelAsyncApiFunction::SetResultFromError(ChannelError error) {
}
CastSocket* CastChannelAsyncApiFunction::GetSocket(int channel_id) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
DCHECK(manager_);
return manager_->Get(extension_->id(), channel_id);
}
void CastChannelAsyncApiFunction::SetResultFromChannelInfo(
const ChannelInfo& channel_info) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
SetResult(channel_info.ToValue().release());
}
@@ -203,7 +203,7 @@ void CastChannelOpenFunction::AsyncWorkStart() {
}
void CastChannelOpenFunction::OnOpen(int result) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
SetResultFromSocket(new_channel_id_);
AsyncWorkCompleted();
}
@@ -227,7 +227,7 @@ void CastChannelSendFunction::AsyncWorkStart() {
}
void CastChannelSendFunction::OnSend(int result) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (result < 0) {
SetResultFromError(cast_channel::CHANNEL_ERROR_SOCKET_ERROR);
} else {
@@ -254,7 +254,7 @@ void CastChannelCloseFunction::AsyncWorkStart() {
}
void CastChannelCloseFunction::OnClose(int result) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
VLOG(1) << "CastChannelCloseFunction::OnClose result = " << result;
if (result < 0) {
SetResultFromError(cast_channel::CHANNEL_ERROR_SOCKET_ERROR);
« no previous file with comments | « chrome/browser/extensions/api/browsing_data/browsing_data_api.cc ('k') | chrome/browser/extensions/api/cookies/cookies_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698