chrome/browser/android/data_usage/data_use_tab_model.h - Issue 2165123002: Make ExternalDataUseReporter independent of other data use classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/data_usage/data_use_tab_model.h

Issue 2165123002: Make ExternalDataUseReporter independent of other data use classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/android/data_usage/data_use_tab_model.cc » ('j') | chrome/browser/android/data_usage/external_data_use_reporter.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/data_usage/data_use_tab_model.h

diff --git a/chrome/browser/android/data_usage/data_use_tab_model.h b/chrome/browser/android/data_usage/data_use_tab_model.h

index fde9e92e1862c0ef95639b415d738228dd41844e..b00656654993bcead8dbfb0f546ecee3b255a32d 100644

--- a/chrome/browser/android/data_usage/data_use_tab_model.h

+++ b/chrome/browser/android/data_usage/data_use_tab_model.h

@@ -151,7 +151,7 @@ class DataUseTabModel {

// returns false.

virtual bool GetTrackingInfoForTabAtTime(

SessionID::id_type tab_id,

- base::TimeTicks timestamp,

+ const base::TimeTicks& timestamp,

tbansal1 2016/07/21 00:19:30 Passing by value is preferable. See https://cs.chr

Raj 2016/07/21 04:09:16 Done.

TrackingInfo* output_tracking_info) const;

// Returns true if the navigation event would end the tracking session for

« no previous file with comments | « no previous file | chrome/browser/android/data_usage/data_use_tab_model.cc » ('j') | chrome/browser/android/data_usage/external_data_use_reporter.h » ('J')