Enter overview mode if lone tab is closed using back button

Enter overview mode if lone tab is closed using back button

Previously if a tab was closed using the back button and it was the
only tab, the browser would stay in StaticLayout. Opening an external
link after this would trigger the overview mode because there was no
tab, then immediately switch to StaticLayout again. This would leave
the toolbar is a bad state. This change adds a check to determine if
there are any other tabs when closing with the back button, if not
overview mode is opened.

BUG=625077
Committed: https://crrev.com/eac0d41a7ec0c5654c31a07c4bfe01363a35c329
Cr-Commit-Position: refs/heads/master@{#406863}

[mdjones, 2016-07-20 22:06:30]

mdjones@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[mdjones, 2016-07-20 22:06:31]

ptal

[gone, 2016-07-20 23:52:20]

lgtm % commenting on how this actually addresses the bug.

[mdjones, 2016-07-21 01:19:33]

Description was changed from

==========
Enter overview mode if lone tab is closed using back button

Using the back button to close a tab opened by an external app would
not re-enter overview mode if it was the only tab. This change adds a
check to determine if there are any other tabs when closing with the
back button, if not overview mode is opened.

BUG=625077
==========

to

==========
Enter overview mode if lone tab is closed using back button

Previously if a tab was closed using the back button and it was the
only tab, the browser would stay in StaticLayout. Opening an external
link after this would trigger the overview mode because there was no
tab, then immediately switch to StaticLayout again. This would leave
the toolbar is a bad state. This change adds a check to determine if
there are any other tabs when closing with the back button, if not
overview mode is opened.

BUG=625077
==========

[mdjones, 2016-07-21 01:19:48]

On 2016/07/20 23:52:20, dfalcantara wrote:
> lgtm % commenting on how this actually addresses the bug.

Done.

[mdjones, 2016-07-21 15:21:04]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2016-07-21 15:21:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 15:52:55]

Description was changed from

==========
Enter overview mode if lone tab is closed using back button

Previously if a tab was closed using the back button and it was the
only tab, the browser would stay in StaticLayout. Opening an external
link after this would trigger the overview mode because there was no
tab, then immediately switch to StaticLayout again. This would leave
the toolbar is a bad state. This change adds a check to determine if
there are any other tabs when closing with the back button, if not
overview mode is opened.

BUG=625077
==========

to

==========
Enter overview mode if lone tab is closed using back button

Previously if a tab was closed using the back button and it was the
only tab, the browser would stay in StaticLayout. Opening an external
link after this would trigger the overview mode because there was no
tab, then immediately switch to StaticLayout again. This would leave
the toolbar is a bad state. This change adds a check to determine if
there are any other tabs when closing with the back button, if not
overview mode is opened.

BUG=625077
==========

[commit-bot: I haz the power, 2016-07-21 15:52:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-21 15:54:54]

Description was changed from

==========
Enter overview mode if lone tab is closed using back button

Previously if a tab was closed using the back button and it was the
only tab, the browser would stay in StaticLayout. Opening an external
link after this would trigger the overview mode because there was no
tab, then immediately switch to StaticLayout again. This would leave
the toolbar is a bad state. This change adds a check to determine if
there are any other tabs when closing with the back button, if not
overview mode is opened.

BUG=625077
==========

to

==========
Enter overview mode if lone tab is closed using back button

Previously if a tab was closed using the back button and it was the
only tab, the browser would stay in StaticLayout. Opening an external
link after this would trigger the overview mode because there was no
tab, then immediately switch to StaticLayout again. This would leave
the toolbar is a bad state. This change adds a check to determine if
there are any other tabs when closing with the back button, if not
overview mode is opened.

BUG=625077

Committed: https://crrev.com/eac0d41a7ec0c5654c31a07c4bfe01363a35c329
Cr-Commit-Position: refs/heads/master@{#406863}
==========

[commit-bot: I haz the power, 2016-07-21 15:54:55]

Patchset 1 (id:??) landed as
https://crrev.com/eac0d41a7ec0c5654c31a07c4bfe01363a35c329
Cr-Commit-Position: refs/heads/master@{#406863}