Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2165023004: Removing autofill addresses should not crash PaymentRequest (Closed)

Created:
4 years, 5 months ago by please use gerrit instead
Modified:
4 years, 5 months ago
Reviewers:
gone
CC:
chromium-reviews, rouslan+autofill_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing autofill addresses should not crash PaymentRequest BUG=630056 Committed: https://crrev.com/6b49e38ad8f0bf3c4f02eeb23134008ff9c47669 Cr-Commit-Position: refs/heads/master@{#407071}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/android/java_sources.gni View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java View 1 1 chunk +1 line, -1 line 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestRemoveBillingAddressTest.java View 1 1 chunk +81 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
please use gerrit instead
dfalcantara@, ptal patch 2.
4 years, 5 months ago (2016-07-21 03:00:21 UTC) #4
gone
lgtm
4 years, 5 months ago (2016-07-22 00:51:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165023004/20001
4 years, 5 months ago (2016-07-22 01:29:56 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-22 05:18:18 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 05:20:09 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6b49e38ad8f0bf3c4f02eeb23134008ff9c47669
Cr-Commit-Position: refs/heads/master@{#407071}

Powered by Google App Engine
This is Rietveld 408576698