extensions/shell/common/shell_extensions_client.h - Issue 2165023003: [Extensions] Use compiled feature files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/common/shell_extensions_client.h

Issue 2165023003: [Extensions] Use compiled feature files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/shell/common/shell_extensions_client.h

diff --git a/extensions/shell/common/shell_extensions_client.h b/extensions/shell/common/shell_extensions_client.h

index 9f0624950aec68c4dfeff7b61f2ac90c57514245..ed07ad2562f9de2a7f61d1897937eeb2adbea771 100644

--- a/extensions/shell/common/shell_extensions_client.h

+++ b/extensions/shell/common/shell_extensions_client.h

@@ -25,8 +25,8 @@ class ShellExtensionsClient : public ExtensionsClient {

const std::string GetProductName() override;

std::unique_ptr<FeatureProvider> CreateFeatureProvider(

const std::string& name) const override;

- std::unique_ptr<JSONFeatureProviderSource> CreateFeatureProviderSource(

- const std::string& name) const override;

+ std::unique_ptr<JSONFeatureProviderSource> CreateAPIFeatureSource()

+ const override;

void FilterHostPermissions(const URLPatternSet& hosts,

URLPatternSet* new_hosts,

PermissionIDSet* permissions) const override;