Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: extensions/common/extensions_client.h

Issue 2165023003: [Extensions] Use compiled feature files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/BUILD.gn ('k') | extensions/common/features/simple_feature.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/extensions_client.h
diff --git a/extensions/common/extensions_client.h b/extensions/common/extensions_client.h
index b897fb889e84c025053eacb83628950cf96fb397..f1c9a27efae6a1a083a6f7ebff0afa9b7ae8f009 100644
--- a/extensions/common/extensions_client.h
+++ b/extensions/common/extensions_client.h
@@ -57,12 +57,10 @@ class ExtensionsClient {
virtual std::unique_ptr<FeatureProvider> CreateFeatureProvider(
const std::string& name) const = 0;
- // Create a JSONFeatureProviderSource for a specific feature type,
- // e.g. "permission". Currently, all features are loaded from
- // JSONFeatureProviderSources.
- // This is used primarily in CreateFeatureProvider, above.
- virtual std::unique_ptr<JSONFeatureProviderSource>
- CreateFeatureProviderSource(const std::string& name) const = 0;
+ // Returns the dictionary of the API features json file.
+ // TODO(devlin): We should find a way to remove this.
+ virtual std::unique_ptr<JSONFeatureProviderSource> CreateAPIFeatureSource()
+ const = 0;
// Takes the list of all hosts and filters out those with special
// permission strings. Adds the regular hosts to |new_hosts|,
« no previous file with comments | « extensions/BUILD.gn ('k') | extensions/common/features/simple_feature.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698