Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2164993002: Update linux-syscall-support to 3f6478ac95edf86cd3da300c2c0d34a438f5dbeb (Closed)

Created:
4 years, 5 months ago by Mark Mentovai
Modified:
4 years, 5 months ago
Reviewers:
Mark Seaborn
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Update linux-syscall-support to 3f6478ac95edf86cd3da300c2c0d34a438f5dbeb Note that the linux-syscall-support repository has moved to a new location. 2ce6a9744160 Add codereview.settings for new repo location cd0177fdded9 Fix VIEW_VC URL in codereview.settings 929203010984 Finally fix VIEW_VC url with proper review 08056836f2b4 migrate site/wiki docs over 348bdf8d32b3 README: clearly document goals/APIs/supported systems 3f6478ac95ed Add s390/s390x support to linux_syscall_support.h This linux-syscall-support update no longer uses sys_mmap2(). sys_mmap() may now be used everywhere. This also updates Breakpad to d5f42abb82722b29d935aeedd8c0aecec6a079d0 for compatibility with the updated linux-syscall-support. Note that the Breakpad repository has moved to a new location. The hash in the new Breakpad repository of the revision previously used in Native Client is cfaf27c37e3e5df5ca00a75758a36af870b5fb45. This update includes 226 commits, so they are not listed individually here. Since Breakpad 728bcdff610a, a C++11 compiler is required, and the default system compiler on the bots may not provide this support. This also contains a change to use the downloaded clang and sysroot, which should always provide the necessary support. BUG=chromium:629874 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/412a6e2bb153f39f22b9b3e47bc1ed0abb82df3f

Patch Set 1 #

Patch Set 2 : Revert Breakpad update #

Patch Set 3 : Keep Breakpad update #

Patch Set 4 : Use the downloaded clang and sysroot for the Breakpad build #

Patch Set 5 : Only use the target architecture for Breakpad if it's an x86 variant #

Patch Set 6 : Fix spaces #

Patch Set 7 : Remove bogus slash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M DEPS View 2 4 chunks +4 lines, -4 lines 0 comments Download
M buildbot/buildbot_standard.py View 1 2 3 4 5 6 2 chunks +20 lines, -3 lines 0 comments Download
M src/trusted/service_runtime/linux/nacl_bootstrap.c View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Mark Mentovai
4 years, 5 months ago (2016-07-21 22:04:03 UTC) #5
Mark Seaborn
LGTM
4 years, 5 months ago (2016-07-21 22:09:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164993002/120001
4 years, 5 months ago (2016-07-22 01:45:33 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 02:27:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/native_client/src/native_client/+/412a6e2bb...

Powered by Google App Engine
This is Rietveld 408576698