Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2164973002: Revert of Use "-Os" for Android or IOS in "optimize_max" config (Closed)

Created:
4 years, 5 months ago by huapengl
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke, sdefresne
CC:
chromium-reviews, sdefresne
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use "-Os" for Android or IOS in "optimize_max" config (patchset #1 id:1 of https://codereview.chromium.org/2158053002/ ) Reason for revert: 8.1% regression in speedometer at 406285:406306 https://bugs.chromium.org/p/chromium/issues/detail?id=629798#c4 Original issue's description: > Use "-Os" for Android or IOS in "optimize_max" config > > Using "-Os" would benefit both Android and IOS build, because "-Os" does > "-O2" optimizations and code size improvement. > > libchrome.so drops from 44MB to 42 MB. > ChromePublic.apk drops from 47 MB to 45 MB. > > BUG=621335 > > Committed: https://crrev.com/2bb3c4f7a7c7632afe1b63a19d49daa61bbfc37b > Cr-Commit-Position: refs/heads/master@{#406304} TBR=dpranke@chromium.org,sdefresne@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=621335 Committed: https://crrev.com/8f5987c15bd03c5da97aa27103d36c5943e78259 Cr-Commit-Position: refs/heads/master@{#406569}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
huapengl
Created Revert of Use "-Os" for Android or IOS in "optimize_max" config
4 years, 5 months ago (2016-07-20 15:41:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164973002/1
4 years, 5 months ago (2016-07-20 15:42:02 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-20 15:42:03 UTC) #5
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-20 16:05:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164973002/1
4 years, 5 months ago (2016-07-20 16:08:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 16:09:05 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 16:09:12 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 16:10:45 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f5987c15bd03c5da97aa27103d36c5943e78259
Cr-Commit-Position: refs/heads/master@{#406569}

Powered by Google App Engine
This is Rietveld 408576698