Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 216493005: Remove scaleToFit from DashPathEffect (Closed)

Created:
6 years, 9 months ago by egdaniel
Modified:
6 years, 8 months ago
Reviewers:
scroggo, bsalomon, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove scaleToFit from DashPathEffect BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13999

Patch Set 1 #

Patch Set 2 : Remove scale calls #

Patch Set 3 : Dummy Read/writes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -33 lines) Patch
M bench/DashBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/dashing.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkDashPathEffect.h View 3 chunks +3 lines, -5 lines 0 comments Download
M src/effects/SkDashPathEffect.cpp View 1 2 7 chunks +7 lines, -25 lines 0 comments Download
M tests/DrawPathTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
egdaniel
All Dash effects in GM, tests, bench set ScaleToFit to false to removing it should ...
6 years, 9 months ago (2014-03-28 16:20:36 UTC) #1
egdaniel
6 years, 9 months ago (2014-03-28 16:29:04 UTC) #2
reed1
api lgtm -- will you be able to read/wrote skp files in a compatible way? ...
6 years, 9 months ago (2014-03-28 16:30:26 UTC) #3
egdaniel
Actually it probably will mess with the reading back skps, and thus need a version ...
6 years, 9 months ago (2014-03-28 16:36:21 UTC) #4
scroggo
On 2014/03/28 16:30:26, reed1 wrote: > api lgtm -- will you be able to read/wrote ...
6 years, 9 months ago (2014-03-28 16:38:29 UTC) #5
reed1
read/write dummy value (for now, with a comment) sgtm
6 years, 9 months ago (2014-03-28 16:41:43 UTC) #6
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 8 months ago (2014-03-31 17:40:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/216493005/40001
6 years, 8 months ago (2014-03-31 17:40:25 UTC) #8
egdaniel
The CQ bit was unchecked by egdaniel@google.com
6 years, 8 months ago (2014-03-31 18:52:20 UTC) #9
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 8 months ago (2014-03-31 18:52:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/216493005/40001
6 years, 8 months ago (2014-03-31 18:52:38 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 18:52:54 UTC) #12
Message was sent while issue was closed.
Change committed as 13999

Powered by Google App Engine
This is Rietveld 408576698