Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Issue 2164923002: Make toLocaleString on arrays always call toLocaleString on its elements. (Closed)

Created:
4 years, 5 months ago by neis
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Dan Ehrenberg
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make toLocaleString on arrays always call toLocaleString on its elements. As required by the spec. This is a variant of what I reverted in f47e7224034261bf62167a36959d5e287c4fc136. It will probably still cause a regression but now it's easier to migrate (parts of) the current implementation to C++, which is expected to make things faster again. BUG=chromium:627729, v8:5113 Committed: https://crrev.com/f2c2ef1f0e4b9fa260179fc53a5995ec93ee2ed6 Cr-Commit-Position: refs/heads/master@{#37897}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -65 lines) Patch
M src/js/array.js View 8 chunks +21 lines, -53 lines 0 comments Download
M test/mjsunit/array-tostring.js View 2 chunks +23 lines, -1 line 0 comments Download
M test/mjsunit/es6/typedarray-tostring.js View 1 chunk +13 lines, -0 lines 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
neis
ptal
4 years, 5 months ago (2016-07-20 09:01:38 UTC) #7
Benedikt Meurer
lgtm
4 years, 5 months ago (2016-07-20 09:02:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164923002/20001
4 years, 5 months ago (2016-07-20 09:29:32 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 5 months ago (2016-07-20 09:32:03 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 09:32:30 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2c2ef1f0e4b9fa260179fc53a5995ec93ee2ed6
Cr-Commit-Position: refs/heads/master@{#37897}

Powered by Google App Engine
This is Rietveld 408576698