Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: src/accessors.cc

Issue 2164903004: Eagerly format traces in captureStackTrace (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/builtins/builtins-error.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/accessors.cc
diff --git a/src/accessors.cc b/src/accessors.cc
index 2dcc367d36383eb51a70a33fb9563672b94eee97..ea69b6fd00cd5ff843451986a86f33769bdf83f0 100644
--- a/src/accessors.cc
+++ b/src/accessors.cc
@@ -1132,24 +1132,6 @@ MaybeHandle<JSReceiver> ClearInternalStackTrace(Isolate* isolate,
return error;
}
-MaybeHandle<Object> FormatStackTrace(Isolate* isolate, Handle<JSObject> error,
- Handle<Object> stack_trace) {
- // TODO(jgruber): Port FormatStackTrace from JS.
- Handle<JSFunction> fun = isolate->error_format_stack_trace();
-
- int argc = 2;
- ScopedVector<Handle<Object>> argv(argc);
- argv[0] = error;
- argv[1] = stack_trace;
-
- Handle<Object> formatted_stack_trace;
- ASSIGN_RETURN_ON_EXCEPTION(
- isolate, formatted_stack_trace,
- Execution::Call(isolate, fun, error, argc, argv.start()), Object);
-
- return formatted_stack_trace;
-}
-
bool IsAccessor(Handle<Object> receiver, Handle<Name> name,
Handle<JSObject> holder) {
LookupIterator it(receiver, name, holder,
« no previous file with comments | « no previous file | src/builtins/builtins-error.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698