Eagerly format traces in captureStackTrace

Eagerly format traces in captureStackTrace

This allows us to skip complicated logic for setting the accessors.

BUG=

Committed: https://crrev.com/4feafee9d9741259e8ec3882fb61935a235ecc54
Cr-Commit-Position: refs/heads/master@{#37969}

[jgruber, 2016-07-21 13:38:18]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 13:38:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-07-21 13:56:29]

jgruber@chromium.org changed reviewers:
+ yangguo@chromium.org

[commit-bot: I haz the power, 2016-07-21 14:01:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 14:01:40]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-07-21 15:59:12]

On 2016/07/21 13:56:30, jgruber wrote:

lgtm.

[jgruber, 2016-07-21 16:17:10]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2016-07-21 16:17:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 16:19:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 16:19:23]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/19977)

[jgruber, 2016-07-22 07:49:51]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-07-22 07:49:51]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2164903004/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-07-22 07:49:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 08:14:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-22 08:14:57]

Description was changed from

==========
Eagerly format traces in captureStackTrace

This allows us to skip complicated logic for setting the accessors.

BUG=
==========

to

==========
Eagerly format traces in captureStackTrace

This allows us to skip complicated logic for setting the accessors.

BUG=

Committed: https://crrev.com/4feafee9d9741259e8ec3882fb61935a235ecc54
Cr-Commit-Position: refs/heads/master@{#37969}
==========

[commit-bot: I haz the power, 2016-07-22 08:14:58]

Patchset 2 (id:??) landed as
https://crrev.com/4feafee9d9741259e8ec3882fb61935a235ecc54
Cr-Commit-Position: refs/heads/master@{#37969}

[ofrobots, 2016-07-22 22:30:20]

Note that this breaks the V8 + Node integration build, see here:
https://build.chromium.org/p/client.v8.fyi/builders/V8%20-%20node.js%20integr...

--------------
var util = require('util');
function CustomError(msg) {
  Error.call(this);
  Object.defineProperty(this, 'message',
                        { value: msg, enumerable: false });
  Object.defineProperty(this, 'name',
                        { value: 'CustomError', enumerable: false });
  Error.captureStackTrace(this, CustomError);
}
util.inherits(CustomError, Error);
const customError = new CustomError('bar');
console.log(Object.keys(customError));
--------------

Object.keys used to return an empty list before but now it returns [ 'stack' ].