Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1635)

Unified Diff: runtime/observatory/lib/src/elements/nav/library_menu_wrapper.dart

Issue 2164903003: Converted Observatory library-nav-menu element (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Adding _getBoolAttribute helper method Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/nav/library_menu_wrapper.dart
diff --git a/runtime/observatory/lib/src/elements/nav/menu_wrapper.dart b/runtime/observatory/lib/src/elements/nav/library_menu_wrapper.dart
similarity index 51%
copy from runtime/observatory/lib/src/elements/nav/menu_wrapper.dart
copy to runtime/observatory/lib/src/elements/nav/library_menu_wrapper.dart
index b96fd0c935d45323466d59440e08104b007aa407..6e48155a2d6e4d5ed2a595e2aab7f8466a86dbd2 100644
--- a/runtime/observatory/lib/src/elements/nav/menu_wrapper.dart
+++ b/runtime/observatory/lib/src/elements/nav/library_menu_wrapper.dart
@@ -5,39 +5,32 @@
import 'dart:html';
import 'package:observatory/app.dart';
+import 'package:observatory/service.dart';
import 'package:observatory/src/elements/helpers/tag.dart';
import 'package:observatory/src/elements/shims/binding.dart';
-import 'package:observatory/src/elements/nav/menu.dart';
+import 'package:observatory/src/elements/nav/library_menu.dart';
-class NavMenuElementWrapper extends HtmlElement {
- static final binder = new Binder<NavMenuElementWrapper>(
- const [const Binding('anchor'), const Binding('link'),
- const Binding('last')]);
+class NavLibraryMenuElementWrapper extends HtmlElement {
+ static final binder = new Binder<NavLibraryMenuElementWrapper>(
+ const [const Binding('last'), const Binding('library')]);
static const tag =
- const Tag<NavMenuElementWrapper>('nav-menu');
+ const Tag<NavLibraryMenuElementWrapper>('library-nav-menu');
- String _anchor = '---';
- String _link;
bool _last = false;
- String get anchor => _anchor;
- String get link => _link;
+ Library _library;
bool get last => _last;
- set anchor(String value) {
- _anchor = value; render();
- }
- set link(String value) {
- _link = value; render();
- }
+ Library get library => _library;
set last(bool value) {
_last = value; render();
}
+ set library(Library value) {
+ _library = value; render();
+ }
- NavMenuElementWrapper.created() : super.created() {
+ NavLibraryMenuElementWrapper.created() : super.created() {
binder.registerCallback(this);
- _anchor = getAttribute('anchor');
- _link = getAttribute('link');
- _last = getAttribute('') != null;
+ _last = _getBoolAttribute('last');
createShadowRoot();
render();
}
@@ -50,12 +43,17 @@ class NavMenuElementWrapper extends HtmlElement {
void render() {
shadowRoot.children = [];
- if (_anchor == null || _last == null) return;
+ if (_library == null || _last == null) return;
shadowRoot.children = [
- new NavMenuElement(_anchor, link: _link, last: last,
+ new NavLibraryMenuElement(library.isolate, library, last: last,
queue: ObservatoryApplication.app.queue)
..children = [new ContentElement()]
];
}
+
+ bool _getBoolAttribute(String name) {
+ final String value = getAttribute(name);
+ return !(value == null || value == 'false');
+ }
}

Powered by Google App Engine
This is Rietveld 408576698