Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2164903003: Converted Observatory library-nav-menu element (Closed)

Created:
4 years, 5 months ago by cbernaschina
Modified:
4 years, 5 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Mock objects can be const #

Patch Set 3 : Adding _getBoolAttribute helper method #

Total comments: 3

Patch Set 4 : Marge with master #

Patch Set 5 : Merge with master #

Patch Set 6 : Added Uris helper function #

Patch Set 7 : Merged with master #

Patch Set 8 : Added missing file into observatory_sources.gypi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -139 lines) Patch
M runtime/observatory/lib/elements.dart View 1 2 3 4 5 6 4 chunks +5 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/mocks.dart View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_tree.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_view.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/code_view.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/context_view.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/error_view.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/field_view.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/flag_list.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/function_view.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/general_error.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_map.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_profile.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_snapshot.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/icdata_view.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_view.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/instructions_view.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/io_view.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_reconnect.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_view.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/json_view.html View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/library_view.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/logging.html View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/megamorphiccache_view.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/metrics.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
A + runtime/observatory/lib/src/elements/nav/library_menu.dart View 1 2 3 4 5 6 1 chunk +15 lines, -19 lines 0 comments Download
A + runtime/observatory/lib/src/elements/nav/library_menu_wrapper.dart View 1 2 3 4 5 6 2 chunks +12 lines, -12 lines 0 comments Download
D runtime/observatory/lib/src/elements/nav_bar.dart View 1 2 3 4 5 6 1 chunk +0 lines, -17 lines 0 comments Download
D runtime/observatory/lib/src/elements/nav_bar.html View 1 2 3 4 5 6 1 chunk +0 lines, -14 lines 0 comments Download
M runtime/observatory/lib/src/elements/object_common.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/object_view.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/objectpool_view.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/objectstore_view.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/persistent_handles.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/ports.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_view.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/timeline_page.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_connect.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_view.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
A runtime/observatory/lib/src/mocks/objects/library.dart View 1 2 3 4 5 6 1 chunk +23 lines, -0 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 3 4 5 6 7 3 chunks +5 lines, -2 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/nav/library-menu/element_test.dart View 1 2 3 4 5 6 1 chunk +6 lines, -6 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/nav/library-menu/element_test.html View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 15 (2 generated)
cbernaschina
4 years, 5 months ago (2016-07-20 21:41:49 UTC) #2
cbernaschina
4 years, 5 months ago (2016-07-21 01:07:48 UTC) #3
cbernaschina
4 years, 5 months ago (2016-07-21 18:30:09 UTC) #4
Cutch
LGTM with a helper method -- why not continue to use makeLink? https://codereview.chromium.org/2164903003/diff/40001/runtime/observatory/lib/src/elements/nav/library_menu.dart File runtime/observatory/lib/src/elements/nav/library_menu.dart ...
4 years, 5 months ago (2016-07-22 13:33:34 UTC) #5
cbernaschina
https://codereview.chromium.org/2164903003/diff/40001/runtime/observatory/lib/src/elements/nav/library_menu.dart File runtime/observatory/lib/src/elements/nav/library_menu.dart (right): https://codereview.chromium.org/2164903003/diff/40001/runtime/observatory/lib/src/elements/nav/library_menu.dart#newcode55 runtime/observatory/lib/src/elements/nav/library_menu.dart:55: link: new Uri(path: '/inspect', On 2016/07/22 13:33:34, Cutch wrote: ...
4 years, 5 months ago (2016-07-22 16:58:55 UTC) #6
cbernaschina
https://codereview.chromium.org/2164903003/diff/40001/runtime/observatory/lib/src/elements/nav/library_menu.dart File runtime/observatory/lib/src/elements/nav/library_menu.dart (right): https://codereview.chromium.org/2164903003/diff/40001/runtime/observatory/lib/src/elements/nav/library_menu.dart#newcode55 runtime/observatory/lib/src/elements/nav/library_menu.dart:55: link: new Uri(path: '/inspect', On 2016/07/22 13:33:34, Cutch wrote: ...
4 years, 5 months ago (2016-07-22 22:50:13 UTC) #7
cbernaschina
4 years, 5 months ago (2016-07-22 23:36:00 UTC) #8
rmacnak
The library id seems to get double escaped somewhere. If I click on the library ...
4 years, 5 months ago (2016-07-23 00:06:06 UTC) #9
cbernaschina
It is reproducible after the last patch?
4 years, 5 months ago (2016-07-23 00:14:18 UTC) #10
cbernaschina
On 2016/07/23 00:14:18, cbernaschina wrote: Is it reproducible after the last patch?
4 years, 5 months ago (2016-07-23 00:14:56 UTC) #11
cbernaschina
4 years, 5 months ago (2016-07-24 21:25:09 UTC) #12
rmacnak
lgtm
4 years, 5 months ago (2016-07-25 16:33:18 UTC) #13
cbernaschina
4 years, 5 months ago (2016-07-25 16:36:26 UTC) #15
Message was sent while issue was closed. 
Committed patchset #8 (id:140001) manually as
f5e157f7d0d8e140b6b4fd91e7216edd94b18d60 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698