content/browser/utility_process_host_impl.cc - Issue 2164883003: Delete SandboxedProcessLauncherDelegate::TakeIpcFd.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/utility_process_host_impl.cc

Issue 2164883003: Delete SandboxedProcessLauncherDelegate::TakeIpcFd. Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-ppapi-channel-mojo

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | content/public/common/sandboxed_process_launcher_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/utility_process_host_impl.cc

diff --git a/content/browser/utility_process_host_impl.cc b/content/browser/utility_process_host_impl.cc

index 64c7888620af616bf567dfb521d34b1bc6eda4e0..5739ad558475635f602c7bf420e10b32aba1838e 100644

--- a/content/browser/utility_process_host_impl.cc

+++ b/content/browser/utility_process_host_impl.cc

@@ -76,11 +76,10 @@ class UtilitySandboxedProcessLauncherDelegate

#if defined(OS_WIN)

launch_elevated_(launch_elevated)

#elif defined(OS_POSIX)

- env_(env),

+ env_(env)

#if !defined(OS_MACOSX) && !defined(OS_ANDROID)

- no_sandbox_(no_sandbox),

+ , no_sandbox_(no_sandbox)

#endif // !defined(OS_MACOSX) && !defined(OS_ANDROID)

- ipc_fd_(host->TakeClientFileDescriptor())

#endif // OS_WIN

{}

@@ -117,7 +116,6 @@ class UtilitySandboxedProcessLauncherDelegate

}

#endif // !defined(OS_MACOSX) && !defined(OS_ANDROID)

base::EnvironmentMap GetEnvironment() override { return env_; }

- base::ScopedFD TakeIpcFd() override { return std::move(ipc_fd_); }

#endif // OS_WIN

SandboxType GetSandboxType() override {

@@ -134,7 +132,6 @@ class UtilitySandboxedProcessLauncherDelegate

#if !defined(OS_MACOSX) && !defined(OS_ANDROID)

bool no_sandbox_;

#endif // !defined(OS_MACOSX) && !defined(OS_ANDROID)

- base::ScopedFD ipc_fd_;

#endif // OS_WIN

};