Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2164873002: [Merge to M53] Worker: Remove locking from WorkerThread::postTask() (Closed)

Created:
4 years, 5 months ago by nhiroki
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Merge to M53] Worker: Remove locking from WorkerThread::postTask() WorkerThread::postTask() can be called from various places and locking in the function may lead to deadlock. To avoid the problem, this CL removes locking from WorkerThread::postTask() and makes it possible to safely access to shared flags without locking. BUG=620442 Review-Url: https://codereview.chromium.org/2142273004 Cr-Commit-Position: refs/heads/master@{#405715} (cherry picked from commit 18d1be3c48e503e5d080361f8fe6df7cfd2b503e) Committed: https://chromium.googlesource.com/chromium/src/+/b70891a44868d73034b78417cad991307819e5a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -17 lines) Patch
M third_party/WebKit/Source/core/workers/WorkerThread.h View 2 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 5 chunks +22 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
nhiroki
4 years, 5 months ago (2016-07-20 01:45:36 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b70891a44868d73034b78417cad991307819e5a5.

Powered by Google App Engine
This is Rietveld 408576698