Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java

Issue 2164863002: Fix CronetHttpURLConnectionTest#testServerHangsUp flake (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: self review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
index bc8ef9873c3d469884bf32c6cd2cc343154c5dc0..3cb8aa50eaecbc62b28253847b618fda43620061 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
@@ -846,17 +846,8 @@ public class CronetHttpURLConnectionTest extends CronetTestBase {
@Feature({"Cronet"})
@CompareDefaultWithCronet
public void testServerHangsUp() throws Exception {
- URL url = new URL(NativeTestServer.getEchoBodyURL());
+ URL url = new URL(NativeTestServer.getInfiniteResponseURL());
final HttpURLConnection connection = (HttpURLConnection) url.openConnection();
- // Make the server echo a large request body, so it exceeds the internal
- // read buffer.
- connection.setDoOutput(true);
- connection.setRequestMethod("POST");
- byte[] largeData = TestUtil.getLargeData();
- connection.setFixedLengthStreamingMode(largeData.length);
- OutputStream out = connection.getOutputStream();
- out.write(largeData);
-
InputStream in = connection.getInputStream();
// Read one byte and shut down the server.
assertTrue(in.read() != 1);

Powered by Google App Engine
This is Rietveld 408576698