Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2164833002: Use surface contents scale from effect tree (3) (Closed)

Created:
4 years, 5 months ago by jaydasika
Modified:
4 years, 5 months ago
Reviewers:
ajuma, weiliangc
CC:
chromium-reviews, cc-bugs_chromium.org, sunxd
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use surface contents scale from effect tree (3) With this CL, all call sites in draw_property_utils use surface contents scale from effect tree. BUG=622372 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel Committed: https://crrev.com/baede2d92aa847c591c93e5256e7a957461f0c6b Cr-Commit-Position: refs/heads/master@{#406429}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : dead_code #

Total comments: 9

Patch Set 4 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -67 lines) Patch
M cc/layers/layer_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/layers/render_surface_unittest.cc View 1 2 3 3 chunks +5 lines, -0 lines 0 comments Download
M cc/trees/draw_property_utils.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/draw_property_utils.cc View 1 2 3 5 chunks +41 lines, -23 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 12 chunks +53 lines, -32 lines 0 comments Download
M cc/trees/property_tree.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M cc/trees/property_tree.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
jaydasika
PTAL
4 years, 5 months ago (2016-07-19 21:26:52 UTC) #5
jaydasika
removed some dead code
4 years, 5 months ago (2016-07-19 21:45:59 UTC) #7
ajuma
Generally looks good, I just have some nits. https://codereview.chromium.org/2164833002/diff/40001/cc/layers/render_surface_unittest.cc File cc/layers/render_surface_unittest.cc (right): https://codereview.chromium.org/2164833002/diff/40001/cc/layers/render_surface_unittest.cc#newcode111 cc/layers/render_surface_unittest.cc:111: draw_property_utils::ComputeEffects( ...
4 years, 5 months ago (2016-07-19 21:59:58 UTC) #8
jaydasika
https://codereview.chromium.org/2164833002/diff/40001/cc/layers/render_surface_unittest.cc File cc/layers/render_surface_unittest.cc (right): https://codereview.chromium.org/2164833002/diff/40001/cc/layers/render_surface_unittest.cc#newcode111 cc/layers/render_surface_unittest.cc:111: draw_property_utils::ComputeEffects( On 2016/07/19 21:59:58, ajuma wrote: > Would it ...
4 years, 5 months ago (2016-07-19 22:56:12 UTC) #9
ajuma
Thanks, lgtm https://codereview.chromium.org/2164833002/diff/40001/cc/trees/draw_property_utils.cc File cc/trees/draw_property_utils.cc (right): https://codereview.chromium.org/2164833002/diff/40001/cc/trees/draw_property_utils.cc#newcode1395 cc/trees/draw_property_utils.cc:1395: if (render_surface->TransformTreeIndex() != 0) { On 2016/07/19 ...
4 years, 5 months ago (2016-07-19 23:08:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164833002/60001
4 years, 5 months ago (2016-07-20 00:29:17 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-20 00:35:07 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 00:35:17 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 00:37:02 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/baede2d92aa847c591c93e5256e7a957461f0c6b
Cr-Commit-Position: refs/heads/master@{#406429}

Powered by Google App Engine
This is Rietveld 408576698