Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
216483005:
Disable MediaCanPlayTypeTest on Android (Closed)
|
Created:
6 years, 8 months ago by enne (OOO) Modified:
6 years, 8 months ago Reviewers:
ddorwin CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org, scherkus (not reviewing), amogh.bihani Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionDisable MediaCanPlayTypeTest on Android
R=ddorwin@chromium.org
BUG=53193, 357665
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260506
Patch Set 1 #
Total comments: 2
Patch Set 2 : Move ifdef OOPS #Messages
Total messages: 19 (0 generated)
The problem is isolated to VP9 on some Android devices. I'll update the bug. This is fine to temporarily disable The #ifdef needs to be moved, though. https://codereview.chromium.org/216483005/diff/1/content/browser/media/media_... File content/browser/media/media_canplaytype_browsertest.cc (right): https://codereview.chromium.org/216483005/diff/1/content/browser/media/media_... content/browser/media/media_canplaytype_browsertest.cc:13: #if !defined(OS_ANDROID) This comes before the namespace but the endif also comes before. You really just want to stop running tests, so move it to line 88.
https://codereview.chromium.org/216483005/diff/1/content/browser/media/media_... File content/browser/media/media_canplaytype_browsertest.cc (right): https://codereview.chromium.org/216483005/diff/1/content/browser/media/media_... content/browser/media/media_canplaytype_browsertest.cc:13: #if !defined(OS_ANDROID) On 2014/03/28 18:08:14, ddorwin wrote: > This comes before the namespace but the endif also comes before. > You really just want to stop running tests, so move it to line 88. Done.
lgtm Thanks.
The CQ bit was checked by enne@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/216483005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
The CQ bit was checked by enne@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/216483005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Commit queue rejected this change because the description was changed between the time the change entered the commit queue and the time it was ready to commit. You can safely check the commit box again.
The CQ bit was checked by enne@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/216483005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
The CQ bit was checked by enne@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/216483005/20001
Message was sent while issue was closed.
Change committed as 260506 |
