third_party/WebKit/LayoutTests/accessibility/set-selection-link.html - Issue 2164813003: Fix visible position calculation in accessible setSelection

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/accessibility/set-selection-link.html

Issue 2164813003: Fix visible position calculation in accessible setSelection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Return null VisiblePosition Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4

	5 <div id="main" role="main">

	6

	7 <p id="para">This<br> is a<a href="#g">test</a>of selection</p>

	8

	9 </div>

	10

	11 <script>

	12 test(function()

	13 {

	14 var axPara = accessibilityController.accessibleElementById("para");
	yosin_UTC9 2016/07/27 01:31:14 It is better to have assert_not_equals(window.acc It is better to have assert_not_equals(window.accessibilityController, undefined, 'This test requires accessibilityController'); dmazzoni 2016/07/27 06:45:17 Done Show quoted text On 2016/07/27 at 01:31:14, Yosi_UTC9 wrote: > It is better to have > > assert_not_equals(window.accessibilityController, undefined, > 'This test requires accessibilityController'); Done
	15 var axLastText = axPara.childAtIndex(4);

	16 assert_equals(axLastText.role, "AXRole: AXStaticText");

	17 assert_equals(axLastText.name, "of selection");

	18

	19 axLastText.setSelectedTextRange(0, 2);

	20

	21 var selection = window.getSelection();

	22 var range = selection.getRangeAt(0);

	23

	24 assert_equals(range.toString(), "of");

	25 }, "Select text after a link.");

	26 </script>

	27

	28 <script>
	yosin_UTC9 2016/07/27 01:31:14 You don't need to have hide test sample. Or put \| You don't need to have hide test sample. Or put \|<div id="log"></div>\| dmazzoni 2016/07/27 06:45:17 Removed. Is there a way to have multiple ignored Show quoted text On 2016/07/27 at 01:31:14, Yosi_UTC9 wrote: > You don't need to have hide test sample. > Or put \|<div id="log"></div>\| Removed. Is there a way to have multiple ignored sections? This test works fine, but I've had other tests where the HTML snippet used in the test would mess up parsing the test results.
	29 if (window.testRunner)

	30 document.getElementById("main").style.display = "none";;

	31 </script>

OLD	NEW