Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Side by Side Diff: third_party/WebKit/Source/core/editing/EditingUtilities.h

Issue 2164813003: Fix visible position calculation in accessible setSelection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after
266 // describes what this function returns, since it returns a position before 266 // describes what this function returns, since it returns a position before
267 // specified position due by canonicalization. 267 // specified position due by canonicalization.
268 CORE_EXPORT VisiblePosition firstEditableVisiblePositionAfterPositionInRoot(cons t Position&, ContainerNode&); 268 CORE_EXPORT VisiblePosition firstEditableVisiblePositionAfterPositionInRoot(cons t Position&, ContainerNode&);
269 CORE_EXPORT VisiblePositionInFlatTree firstEditableVisiblePositionAfterPositionI nRoot(const PositionInFlatTree&, ContainerNode&); 269 CORE_EXPORT VisiblePositionInFlatTree firstEditableVisiblePositionAfterPositionI nRoot(const PositionInFlatTree&, ContainerNode&);
270 // TODO(yosin) We should rename 270 // TODO(yosin) We should rename
271 // |lastEditableVisiblePositionBeforePositionInRoot()| to a better name which 271 // |lastEditableVisiblePositionBeforePositionInRoot()| to a better name which
272 // describes what this function returns, since it returns a position after 272 // describes what this function returns, since it returns a position after
273 // specified position due by canonicalization. 273 // specified position due by canonicalization.
274 CORE_EXPORT VisiblePosition lastEditableVisiblePositionBeforePositionInRoot(cons t Position&, ContainerNode&); 274 CORE_EXPORT VisiblePosition lastEditableVisiblePositionBeforePositionInRoot(cons t Position&, ContainerNode&);
275 CORE_EXPORT VisiblePositionInFlatTree lastEditableVisiblePositionBeforePositionI nRoot(const PositionInFlatTree&, ContainerNode&); 275 CORE_EXPORT VisiblePositionInFlatTree lastEditableVisiblePositionBeforePositionI nRoot(const PositionInFlatTree&, ContainerNode&);
276 VisiblePosition visiblePositionBeforeNode(Node&); 276 CORE_EXPORT VisiblePosition visiblePositionBeforeNode(Node&);
277 VisiblePosition visiblePositionAfterNode(Node&); 277 VisiblePosition visiblePositionAfterNode(Node&);
278 278
279 bool lineBreakExistsAtVisiblePosition(const VisiblePosition&); 279 bool lineBreakExistsAtVisiblePosition(const VisiblePosition&);
280 280
281 int comparePositions(const VisiblePosition&, const VisiblePosition&); 281 int comparePositions(const VisiblePosition&, const VisiblePosition&);
282 282
283 int indexForVisiblePosition(const VisiblePosition&, ContainerNode*& scope); 283 CORE_EXPORT int indexForVisiblePosition(const VisiblePosition&, ContainerNode*& scope);
284 EphemeralRange makeRange(const VisiblePosition&, const VisiblePosition&); 284 EphemeralRange makeRange(const VisiblePosition&, const VisiblePosition&);
285 EphemeralRange normalizeRange(const EphemeralRange&); 285 EphemeralRange normalizeRange(const EphemeralRange&);
286 EphemeralRangeInFlatTree normalizeRange(const EphemeralRangeInFlatTree&); 286 EphemeralRangeInFlatTree normalizeRange(const EphemeralRangeInFlatTree&);
287 CORE_EXPORT VisiblePosition visiblePositionForIndex(int index, ContainerNode* sc ope); 287 CORE_EXPORT VisiblePosition visiblePositionForIndex(int index, ContainerNode* sc ope);
288 288
289 // ------------------------------------------------------------------------- 289 // -------------------------------------------------------------------------
290 // HTMLElement 290 // HTMLElement
291 // ------------------------------------------------------------------------- 291 // -------------------------------------------------------------------------
292 292
293 // Functions returning HTMLElement 293 // Functions returning HTMLElement
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 // ------------------------------------------------------------------------- 355 // -------------------------------------------------------------------------
356 356
357 // Functions dispatch InputEvent 357 // Functions dispatch InputEvent
358 DispatchEventResult dispatchBeforeInputInsertText(EventTarget*, const String& da ta); 358 DispatchEventResult dispatchBeforeInputInsertText(EventTarget*, const String& da ta);
359 DispatchEventResult dispatchBeforeInputFromComposition(EventTarget*, InputEvent: :InputType, const String& data, InputEvent::EventCancelable); 359 DispatchEventResult dispatchBeforeInputFromComposition(EventTarget*, InputEvent: :InputType, const String& data, InputEvent::EventCancelable);
360 DispatchEventResult dispatchBeforeInputEditorCommand(EventTarget*, InputEvent::I nputType, const String& data, const RangeVector*); 360 DispatchEventResult dispatchBeforeInputEditorCommand(EventTarget*, InputEvent::I nputType, const String& data, const RangeVector*);
361 361
362 } // namespace blink 362 } // namespace blink
363 363
364 #endif 364 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698