Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2164803003: Window cycle ui improvements (Closed)

Created:
4 years, 5 months ago by Evan Stade
Modified:
4 years, 5 months ago
Reviewers:
rkaplow, sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Window cycle ui improvements - add window title - add padding/adjust preview resizing algorithm - add about:flags entry BUG=626111 TBR=rkaplow@chromium.org Committed: https://crrev.com/13ac61ab1cbaf45830b5617b822f67399e502a65 Cr-Commit-Position: refs/heads/master@{#406902}

Patch Set 1 #

Patch Set 2 : adjust padding, add about:flag #

Total comments: 4

Patch Set 3 : histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -12 lines) Patch
M ash/common/wm/window_cycle_list.cc View 1 3 chunks +126 lines, -1 line 0 comments Download
M ash/wm/window_mirror_view.cc View 1 chunk +1 line, -11 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
Evan Stade
https://codereview.chromium.org/2164803003/diff/20001/ash/wm/window_mirror_view.cc File ash/wm/window_mirror_view.cc (left): https://codereview.chromium.org/2164803003/diff/20001/ash/wm/window_mirror_view.cc#oldcode54 ash/wm/window_mirror_view.cc:54: const int kMaxWidth = 512; Seems like this logic ...
4 years, 5 months ago (2016-07-20 17:01:09 UTC) #3
sky
LGTM https://codereview.chromium.org/2164803003/diff/20001/ash/common/wm/window_cycle_list.cc File ash/common/wm/window_cycle_list.cc (right): https://codereview.chromium.org/2164803003/diff/20001/ash/common/wm/window_cycle_list.cc#newcode223 ash/common/wm/window_cycle_list.cc:223: for (WmWindow* window : windows) { Not related ...
4 years, 5 months ago (2016-07-20 19:48:45 UTC) #4
Evan Stade
https://codereview.chromium.org/2164803003/diff/20001/ash/common/wm/window_cycle_list.cc File ash/common/wm/window_cycle_list.cc (right): https://codereview.chromium.org/2164803003/diff/20001/ash/common/wm/window_cycle_list.cc#newcode223 ash/common/wm/window_cycle_list.cc:223: for (WmWindow* window : windows) { On 2016/07/20 19:48:45, ...
4 years, 5 months ago (2016-07-20 19:53:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164803003/20001
4 years, 5 months ago (2016-07-20 19:54:15 UTC) #7
sky
On Wed, Jul 20, 2016 at 12:53 PM, <estade@chromium.org> wrote: > > https://codereview.chromium.org/2164803003/diff/20001/ash/common/wm/window_cycle_list.cc > File ...
4 years, 5 months ago (2016-07-20 19:55:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/204559)
4 years, 5 months ago (2016-07-20 20:43:43 UTC) #10
Evan Stade
+rkaplow TBR for histograms.xml update
4 years, 5 months ago (2016-07-20 22:24:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164803003/40001
4 years, 5 months ago (2016-07-20 22:25:12 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/247497)
4 years, 5 months ago (2016-07-20 23:39:35 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164803003/40001
4 years, 5 months ago (2016-07-21 17:32:50 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-21 18:07:12 UTC) #22
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 18:09:36 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/13ac61ab1cbaf45830b5617b822f67399e502a65
Cr-Commit-Position: refs/heads/master@{#406902}

Powered by Google App Engine
This is Rietveld 408576698