Window cycle ui improvements

Window cycle ui improvements

- add window title
- add padding/adjust preview resizing algorithm
- add about:flags entry

BUG=626111
TBR=rkaplow@chromium.org

Committed: https://crrev.com/13ac61ab1cbaf45830b5617b822f67399e502a65
Cr-Commit-Position: refs/heads/master@{#406902}

[Evan Stade, 2016-07-20 17:00:16]

Description was changed from

==========
WIP - window cycle ui label + sizing/padding adjustments

BUG=626111
==========

to

==========
Window cycle ui improvements

- add window title
- add padding/adjust preview resizing algorithm
- add about:flags entry

BUG=626111
==========

[Evan Stade, 2016-07-20 17:00:17]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[Evan Stade, 2016-07-20 17:01:09]

https://codereview.chromium.org/2164803003/diff/20001/ash/wm/window_mirror_vi...
File ash/wm/window_mirror_view.cc (left):

https://codereview.chromium.org/2164803003/diff/20001/ash/wm/window_mirror_vi...
ash/wm/window_mirror_view.cc:54: const int kMaxWidth = 512;
Seems like this logic belongs in the window cycle list, so I moved it.

[sky, 2016-07-20 19:48:45]

LGTM

https://codereview.chromium.org/2164803003/diff/20001/ash/common/wm/window_cy...
File ash/common/wm/window_cycle_list.cc (right):

https://codereview.chromium.org/2164803003/diff/20001/ash/common/wm/window_cy...
ash/common/wm/window_cycle_list.cc:223: for (WmWindow* window : windows) {
Not related to this change, but recreating layers isn't cheap. At some point
will you only recreate the layers of a subset of windows?

https://codereview.chromium.org/2164803003/diff/20001/ash/wm/window_mirror_vi...
File ash/wm/window_mirror_view.cc (left):

https://codereview.chromium.org/2164803003/diff/20001/ash/wm/window_mirror_vi...
ash/wm/window_mirror_view.cc:54: const int kMaxWidth = 512;
On 2016/07/20 17:01:09, Evan Stade wrote:
> Seems like this logic belongs in the window cycle list, so I moved it.

Agreed.

[Evan Stade, 2016-07-20 19:53:42]

https://codereview.chromium.org/2164803003/diff/20001/ash/common/wm/window_cy...
File ash/common/wm/window_cycle_list.cc (right):

https://codereview.chromium.org/2164803003/diff/20001/ash/common/wm/window_cy...
ash/common/wm/window_cycle_list.cc:223: for (WmWindow* window : windows) {
On 2016/07/20 19:48:45, sky wrote:
> Not related to this change, but recreating layers isn't cheap. At some point
> will you only recreate the layers of a subset of windows?

Yes. It's an open question whether we want to be able to alt tab through all
windows or just the N MRU (N ~= 10). If we limit it to 10 that would naturally
limit this. But also we can/should defer creating these previews until they'd
actually be visible (given that some of them would start off the edge of the
screen).

[Evan Stade, 2016-07-20 19:53:55]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-07-20 19:54:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-07-20 19:55:20]

On Wed, Jul 20, 2016 at 12:53 PM,  <estade@chromium.org> wrote:
>
>
https://codereview.chromium.org/2164803003/diff/20001/ash/common/wm/window_cy...
> File ash/common/wm/window_cycle_list.cc (right):
>
>
https://codereview.chromium.org/2164803003/diff/20001/ash/common/wm/window_cy...
> ash/common/wm/window_cycle_list.cc:223: for (WmWindow* window : windows)
> {
> On 2016/07/20 19:48:45, sky wrote:
>> Not related to this change, but recreating layers isn't cheap. At some
> point
>> will you only recreate the layers of a subset of windows?
>
> Yes. It's an open question whether we want to be able to alt tab through
> all windows or just the N MRU (N ~= 10). If we limit it to 10 that would
> naturally limit this. But also we can/should defer creating these
> previews until they'd actually be visible (given that some of them would
> start off the edge of the screen).

I was thinking of creating when necessary.

  -Scott
>
> https://codereview.chromium.org/2164803003/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2016-07-20 20:43:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 20:43:43]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2016-07-20 22:24:10]

Description was changed from

==========
Window cycle ui improvements

- add window title
- add padding/adjust preview resizing algorithm
- add about:flags entry

BUG=626111
==========

to

==========
Window cycle ui improvements

- add window title
- add padding/adjust preview resizing algorithm
- add about:flags entry

BUG=626111
TBR=rkaplow@chromium.org
==========

[Evan Stade, 2016-07-20 22:24:10]

estade@chromium.org changed reviewers:
+ rkaplow@chromium.org

[Evan Stade, 2016-07-20 22:24:23]

+rkaplow TBR for histograms.xml update

[Evan Stade, 2016-07-20 22:24:26]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-07-20 22:24:27]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2164803003/#ps40001
(title: "histograms.xml")

[commit-bot: I haz the power, 2016-07-20 22:25:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 23:39:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 23:39:35]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2016-07-21 17:32:09]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-07-21 17:32:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 18:07:10]

Description was changed from

==========
Window cycle ui improvements

- add window title
- add padding/adjust preview resizing algorithm
- add about:flags entry

BUG=626111
TBR=rkaplow@chromium.org
==========

to

==========
Window cycle ui improvements

- add window title
- add padding/adjust preview resizing algorithm
- add about:flags entry

BUG=626111
TBR=rkaplow@chromium.org
==========

[commit-bot: I haz the power, 2016-07-21 18:07:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-21 18:09:35]

Description was changed from

==========
Window cycle ui improvements

- add window title
- add padding/adjust preview resizing algorithm
- add about:flags entry

BUG=626111
TBR=rkaplow@chromium.org
==========

to

==========
Window cycle ui improvements

- add window title
- add padding/adjust preview resizing algorithm
- add about:flags entry

BUG=626111
TBR=rkaplow@chromium.org

Committed: https://crrev.com/13ac61ab1cbaf45830b5617b822f67399e502a65
Cr-Commit-Position: refs/heads/master@{#406902}
==========

[commit-bot: I haz the power, 2016-07-21 18:09:36]

Patchset 3 (id:??) landed as
https://crrev.com/13ac61ab1cbaf45830b5617b822f67399e502a65
Cr-Commit-Position: refs/heads/master@{#406902}