Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2164783005: Adds BrowserAssociatedInterface (Closed)

Created:
4 years, 5 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 4 months ago
Reviewers:
jam
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@early-channel-setup
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds BrowserAssociatedInterface BrowserAssociatedInterface can be implemented in conjunction with BrowserMessageFilter in order to provide browser-side Mojo bindings which dispatch on the IO thread and maintain FIFO with respect to legacy IPC messages on the same channel. BUG=612500, 619202 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/a32ca4b3ff6690d5b164313cd541e7908b8b8499 Cr-Commit-Position: refs/heads/master@{#407644}

Patch Set 1 : . #

Patch Set 2 : rebase #

Patch Set 3 : . #

Patch Set 4 : rebase #

Patch Set 5 : . #

Patch Set 6 : better comments #

Patch Set 7 : no CONTENT_EXPORT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+335 lines, -11 lines) Patch
A content/browser/browser_associated_interface_unittest.cc View 1 2 3 4 1 chunk +170 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
A content/public/browser/browser_associated_interface.h View 1 2 3 4 5 6 1 chunk +121 lines, -0 lines 0 comments Download
M content/public/browser/browser_message_filter.h View 1 2 3 4 4 chunks +17 lines, -3 lines 0 comments Download
M content/public/browser/browser_message_filter.cc View 1 2 3 4 2 chunks +13 lines, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M content/test/OWNERS View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
A + content/test/test_browser_associated_interfaces.mojom View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 44 (37 generated)
Ken Rockot(use gerrit already)
Note that https://codereview.chromium.org/2167513003 actually uses this to give RenderFrameMessageFilter an associated interface (currently incomplete because ...
4 years, 5 months ago (2016-07-22 20:47:13 UTC) #20
jam
lgtm with discussed changes
4 years, 5 months ago (2016-07-22 21:35:47 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164783005/140001
4 years, 5 months ago (2016-07-25 21:14:31 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/58234)
4 years, 4 months ago (2016-07-25 21:50:15 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164783005/160001
4 years, 4 months ago (2016-07-26 00:07:58 UTC) #41
commit-bot: I haz the power
Committed patchset #7 (id:160001)
4 years, 4 months ago (2016-07-26 00:12:56 UTC) #42
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 00:15:24 UTC) #44
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/a32ca4b3ff6690d5b164313cd541e7908b8b8499
Cr-Commit-Position: refs/heads/master@{#407644}

Powered by Google App Engine
This is Rietveld 408576698