Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2164783002: [md] Updates aura tooltip colors and padding to MD (Closed)

Created:
4 years, 5 months ago by varkha
Modified:
4 years, 5 months ago
Reviewers:
tdanderson, sadrul
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[md] Updates aura tooltip colors and padding to MD BUG=607028 Committed: https://crrev.com/15193d33844f5567ef04e6c11972276c4a3eca8e Cr-Commit-Position: refs/heads/master@{#406763}

Patch Set 1 : [md] Updates aura tooltip colors and padding to MD #

Patch Set 2 : [md] Updates aura tooltip colors and padding to MD (designer updates) #

Patch Set 3 : [md] Updates aura tooltip colors and padding to MD (disable subpixel anti-aliasing for transparent … #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -9 lines) Patch
M ui/native_theme/common_theme.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download
M ui/views/corewm/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/corewm/tooltip_aura.cc View 1 2 7 chunks +32 lines, -9 lines 0 comments Download

Messages

Total messages: 28 (18 generated)
varkha
Can you please take a look? This updates yellow tooltips throughout in Aura UI. tdanderson@ ...
4 years, 5 months ago (2016-07-19 20:33:42 UTC) #4
tdanderson
LGTM but please run this by Sebastien first if you haven't already to see if ...
4 years, 5 months ago (2016-07-19 22:05:09 UTC) #10
sadrul
lgtm
4 years, 5 months ago (2016-07-20 16:59:18 UTC) #11
varkha
Thanks. I think (https://cs.chromium.org/search/?q=%22CreateTooltip()%22&sq=package:chromium&type=cs) we are using TooltipWin rather than TootipAura for Windows and we ...
4 years, 5 months ago (2016-07-20 18:29:04 UTC) #12
varkha
checked with sgabriel@ offline. Using the following: - 2px rounded corners - no shadows - ...
4 years, 5 months ago (2016-07-20 21:35:58 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164783002/40001
4 years, 5 months ago (2016-07-20 22:42:10 UTC) #20
varkha
Still need to make sure subpixel text rendering is properly disabled when necessary.
4 years, 5 months ago (2016-07-20 23:01:52 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164783002/60001
4 years, 5 months ago (2016-07-21 03:13:26 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 5 months ago (2016-07-21 03:59:39 UTC) #26
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 04:01:12 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/15193d33844f5567ef04e6c11972276c4a3eca8e
Cr-Commit-Position: refs/heads/master@{#406763}

Powered by Google App Engine
This is Rietveld 408576698