Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2164763007: [Android] Use ensure_goma in android/builder. (Closed)

Created:
4 years, 5 months ago by jbudorick
Modified:
4 years, 5 months ago
Reviewers:
eakuefner
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : only ensure_goma #

Unified diffs Side-by-side diffs Delta from patch set Stats (+510 lines, -23 lines) Patch
M scripts/slave/recipes/android/builder.py View 1 1 chunk +1 line, -0 lines 0 comments Download
D scripts/slave/recipes/android/builder.expected/chromium_android_Android_x64_Builder__dbg__fail_check_licenses.json View 1 3 chunks +56 lines, -2 lines 0 comments Download
D scripts/slave/recipes/android/builder.expected/full_chromium_android_Android_MIPS_Builder__dbg_.json View 1 3 chunks +56 lines, -2 lines 0 comments Download
D scripts/slave/recipes/android/builder.expected/full_chromium_android_Android_x64_Builder__dbg_.json View 1 3 chunks +56 lines, -2 lines 0 comments Download
D scripts/slave/recipes/android/builder.expected/full_chromium_android_Android_x86_Builder__dbg_.json View 1 3 chunks +56 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_chromium_perf_Android_Builder.json View 1 4 chunks +57 lines, -3 lines 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_chromium_perf_Android_arm64_Builder.json View 1 4 chunks +57 lines, -3 lines 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_client_v8_fyi_Android_Builder.json View 1 4 chunks +57 lines, -3 lines 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_tryserver_chromium_perf_android_arm64_perf_bisect_builder.json View 1 4 chunks +57 lines, -3 lines 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_tryserver_chromium_perf_android_perf_bisect_builder.json View 1 4 chunks +57 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jbudorick
4 years, 5 months ago (2016-07-21 21:57:42 UTC) #2
eakuefner
https://codereview.chromium.org/2164763007/diff/1/scripts/slave/recipes/android/builder.py File scripts/slave/recipes/android/builder.py (left): https://codereview.chromium.org/2164763007/diff/1/scripts/slave/recipes/android/builder.py#oldcode29 scripts/slave/recipes/android/builder.py:29: 'chromium.android': { what's all this? https://codereview.chromium.org/2164763007/diff/1/scripts/slave/recipes/android/builder.py#oldcode253 scripts/slave/recipes/android/builder.py:253: def step_failure(mastername, ...
4 years, 5 months ago (2016-07-21 22:06:33 UTC) #3
eakuefner
lgtm although maybe move the chromium.android changes to another CL.
4 years, 5 months ago (2016-07-21 22:18:53 UTC) #4
jbudorick
api.chromium.ensure_goma sets the goma_dir in addition to making sure that it's available in cipd: https://codesearch.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium/api.py?rcl=0&l=474 ...
4 years, 5 months ago (2016-07-21 22:38:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164763007/20001
4 years, 5 months ago (2016-07-21 22:38:27 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 22:42:26 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/c0dfd43ad87b48a4fae3...

Powered by Google App Engine
This is Rietveld 408576698