tool/input_sdk/private/ddc_runtime/rtti.dart - Issue 2164763005: Library custom formatters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tool/input_sdk/private/ddc_runtime/rtti.dart

Issue 2164763005: Library custom formatters (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master

Patch Set: Pub upgrade Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tool/input_sdk/private/ddc_runtime/rtti.dart

diff --git a/tool/input_sdk/private/ddc_runtime/rtti.dart b/tool/input_sdk/private/ddc_runtime/rtti.dart

index 7dd6fd4b39dcece8aaa472f4fce3bb8b702f5f5a..577194a95112bf65482a81f8655377055b110e62 100644

--- a/tool/input_sdk/private/ddc_runtime/rtti.dart

+++ b/tool/input_sdk/private/ddc_runtime/rtti.dart

@@ -74,6 +74,8 @@ lazyFn(closure, computeType) {

// TODO(vsm): How should we encode the runtime type?

final _runtimeType = JS('', 'Symbol("_runtimeType")');

+final isNamedConstructor = JS('', 'Symbol("isNamedConstructor")');

+final dartLibraryName = JS('', 'Symbol("dartLibraryName")');

_checkPrimitiveType(obj) {

// TODO(jmesserly): JS is used to prevent type literal wrapping. Is there a