Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2164763002: DevTools: bring back properties defined on prototype to object dumps in extension tests (Closed)

Created:
4 years, 5 months ago by caseq
Modified:
4 years, 5 months ago
Reviewers:
alph, dgozman
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: bring back properties defined on prototype to object dumps in extension tests Originally regressed here: http://trac.webkit.org/changeset/127164 Committed: https://crrev.com/a3cf0b86fea620a9d17c55efe00acaf86550a807 Cr-Commit-Position: refs/heads/master@{#406404}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/resources/extension-main.js View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-api-expected.txt View 5 chunks +17 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-audits-api-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
caseq
4 years, 5 months ago (2016-07-19 19:20:00 UTC) #2
dgozman
The code lgtm, but I have no idea whether this is "the right thing" to ...
4 years, 5 months ago (2016-07-19 20:19:45 UTC) #3
alph
lgtm
4 years, 5 months ago (2016-07-19 20:43:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164763002/1
4 years, 5 months ago (2016-07-19 21:37:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 22:53:22 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 22:53:24 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 22:54:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3cf0b86fea620a9d17c55efe00acaf86550a807
Cr-Commit-Position: refs/heads/master@{#406404}

Powered by Google App Engine
This is Rietveld 408576698