Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2164753004: Renaming Gnubby and RemoteSecurityKey files/classes/members (Closed)

Created:
4 years, 5 months ago by joedow
Modified:
4 years, 5 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renaming Gnubby and RemoteSecurityKey files/classes/members This change is a simple refactoring to rename the 'Gnubby' and 'RemoteSecurityKey' file/class names/comments/etc to be consistent. I've chosen to use 'SecurityKey' as it is shorter that RemoteSecurityKey (which was causing too many 80 char limit issues). No functional changes are expected as a result of this change. Note: Not every instance of Gnubby or RemoteSecurityKey has been changed. The registry key used for toggling this functionality still uses 'gnubby'. I don't want to change that here. Also, the process used on the host machine is still called remote_security_key so classes associated with that process were not renamed (neither were the IPC messages used by it). BUG=593736 TBR=jochen@chromium.org Committed: https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e Cr-Commit-Position: refs/heads/master@{#406718}

Patch Set 1 #

Patch Set 2 : Fixing a GYP build break #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1421 lines, -8072 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/BUILD.gn View 2 chunks +18 lines, -18 lines 0 comments Download
M remoting/host/host_mock_objects.h View 3 chunks +9 lines, -9 lines 0 comments Download
M remoting/host/host_mock_objects.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 6 chunks +19 lines, -17 lines 0 comments Download
D remoting/host/security_key/fake_ipc_gnubby_auth_handler.h View 1 chunk +0 lines, -72 lines 0 comments Download
D remoting/host/security_key/fake_ipc_gnubby_auth_handler.cc View 1 chunk +0 lines, -63 lines 0 comments Download
A + remoting/host/security_key/fake_ipc_security_key_auth_handler.h View 3 chunks +16 lines, -16 lines 0 comments Download
A + remoting/host/security_key/fake_ipc_security_key_auth_handler.cc View 2 chunks +16 lines, -13 lines 0 comments Download
D remoting/host/security_key/fake_remote_security_key_ipc_client.h View 1 chunk +0 lines, -117 lines 0 comments Download
D remoting/host/security_key/fake_remote_security_key_ipc_client.cc View 1 chunk +0 lines, -130 lines 0 comments Download
D remoting/host/security_key/fake_remote_security_key_ipc_server.h View 1 chunk +0 lines, -136 lines 0 comments Download
D remoting/host/security_key/fake_remote_security_key_ipc_server.cc View 1 chunk +0 lines, -127 lines 0 comments Download
D remoting/host/security_key/fake_remote_security_key_message_reader.h View 1 chunk +0 lines, -48 lines 0 comments Download
D remoting/host/security_key/fake_remote_security_key_message_reader.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D remoting/host/security_key/fake_remote_security_key_message_writer.h View 1 chunk +0 lines, -65 lines 0 comments Download
D remoting/host/security_key/fake_remote_security_key_message_writer.cc View 1 chunk +0 lines, -53 lines 0 comments Download
A + remoting/host/security_key/fake_security_key_ipc_client.h View 4 chunks +9 lines, -9 lines 0 comments Download
A + remoting/host/security_key/fake_security_key_ipc_client.cc View 6 chunks +16 lines, -19 lines 0 comments Download
A + remoting/host/security_key/fake_security_key_ipc_server.h View 5 chunks +23 lines, -25 lines 0 comments Download
A + remoting/host/security_key/fake_security_key_ipc_server.cc View 5 chunks +27 lines, -34 lines 0 comments Download
A + remoting/host/security_key/fake_security_key_message_reader.h View 2 chunks +12 lines, -13 lines 0 comments Download
A + remoting/host/security_key/fake_security_key_message_reader.cc View 2 chunks +6 lines, -6 lines 0 comments Download
A + remoting/host/security_key/fake_security_key_message_writer.h View 3 chunks +16 lines, -21 lines 0 comments Download
A + remoting/host/security_key/fake_security_key_message_writer.cc View 3 chunks +9 lines, -9 lines 0 comments Download
D remoting/host/security_key/gnubby_auth_handler.h View 1 chunk +0 lines, -71 lines 0 comments Download
D remoting/host/security_key/gnubby_auth_handler_android.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D remoting/host/security_key/gnubby_auth_handler_linux.cc View 1 chunk +0 lines, -283 lines 0 comments Download
D remoting/host/security_key/gnubby_auth_handler_linux_unittest.cc View 1 chunk +0 lines, -248 lines 0 comments Download
D remoting/host/security_key/gnubby_auth_handler_mac.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D remoting/host/security_key/gnubby_auth_handler_win.cc View 1 chunk +0 lines, -305 lines 0 comments Download
D remoting/host/security_key/gnubby_auth_handler_win_unittest.cc View 1 chunk +0 lines, -535 lines 0 comments Download
D remoting/host/security_key/gnubby_extension.h View 1 chunk +0 lines, -37 lines 0 comments Download
D remoting/host/security_key/gnubby_extension.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D remoting/host/security_key/gnubby_extension_session.h View 1 chunk +0 lines, -67 lines 0 comments Download
D remoting/host/security_key/gnubby_extension_session.cc View 1 chunk +0 lines, -211 lines 0 comments Download
D remoting/host/security_key/gnubby_extension_session_unittest.cc View 1 chunk +0 lines, -435 lines 0 comments Download
D remoting/host/security_key/gnubby_socket.h View 1 chunk +0 lines, -113 lines 0 comments Download
D remoting/host/security_key/gnubby_socket.cc View 1 chunk +0 lines, -188 lines 0 comments Download
D remoting/host/security_key/remote_security_key_ipc_client.h View 1 chunk +0 lines, -112 lines 0 comments Download
D remoting/host/security_key/remote_security_key_ipc_client.cc View 1 chunk +0 lines, -222 lines 0 comments Download
D remoting/host/security_key/remote_security_key_ipc_client_unittest.cc View 1 chunk +0 lines, -355 lines 0 comments Download
D remoting/host/security_key/remote_security_key_ipc_constants.h View 1 chunk +0 lines, -29 lines 0 comments Download
D remoting/host/security_key/remote_security_key_ipc_constants.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D remoting/host/security_key/remote_security_key_ipc_server.h View 1 chunk +0 lines, -61 lines 0 comments Download
D remoting/host/security_key/remote_security_key_ipc_server.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D remoting/host/security_key/remote_security_key_ipc_server_impl.h View 1 chunk +0 lines, -98 lines 0 comments Download
D remoting/host/security_key/remote_security_key_ipc_server_impl.cc View 1 chunk +0 lines, -194 lines 0 comments Download
D remoting/host/security_key/remote_security_key_ipc_server_unittest.cc View 1 chunk +0 lines, -420 lines 0 comments Download
M remoting/host/security_key/remote_security_key_main.cc View 3 chunks +5 lines, -6 lines 0 comments Download
D remoting/host/security_key/remote_security_key_message_handler.h View 1 chunk +0 lines, -90 lines 0 comments Download
D remoting/host/security_key/remote_security_key_message_handler.cc View 1 chunk +0 lines, -184 lines 0 comments Download
D remoting/host/security_key/remote_security_key_message_handler_unittest.cc View 1 chunk +0 lines, -302 lines 0 comments Download
D remoting/host/security_key/remote_security_key_message_reader.h View 1 chunk +0 lines, -32 lines 0 comments Download
D remoting/host/security_key/remote_security_key_message_reader.cc View 1 chunk +0 lines, -134 lines 0 comments Download
D remoting/host/security_key/remote_security_key_message_reader_impl.h View 1 chunk +0 lines, -72 lines 0 comments Download
D remoting/host/security_key/remote_security_key_message_reader_impl.cc View 1 chunk +0 lines, -144 lines 0 comments Download
D remoting/host/security_key/remote_security_key_message_reader_impl_unittest.cc View 1 chunk +0 lines, -269 lines 0 comments Download
D remoting/host/security_key/remote_security_key_message_writer.h View 1 chunk +0 lines, -31 lines 0 comments Download
D remoting/host/security_key/remote_security_key_message_writer.cc View 1 chunk +0 lines, -82 lines 0 comments Download
D remoting/host/security_key/remote_security_key_message_writer_impl.h View 1 chunk +0 lines, -41 lines 0 comments Download
D remoting/host/security_key/remote_security_key_message_writer_impl.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D remoting/host/security_key/remote_security_key_message_writer_impl_unittest.cc View 1 chunk +0 lines, -204 lines 0 comments Download
A + remoting/host/security_key/security_key_auth_handler.h View 2 chunks +23 lines, -22 lines 0 comments Download
A + remoting/host/security_key/security_key_auth_handler_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/host/security_key/security_key_auth_handler_linux.cc View 9 chunks +81 lines, -76 lines 0 comments Download
A + remoting/host/security_key/security_key_auth_handler_linux_unittest.cc View 9 chunks +22 lines, -22 lines 0 comments Download
A + remoting/host/security_key/security_key_auth_handler_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/host/security_key/security_key_auth_handler_win.cc View 14 chunks +60 lines, -58 lines 0 comments Download
A + remoting/host/security_key/security_key_auth_handler_win_unittest.cc View 20 chunks +159 lines, -140 lines 0 comments Download
A + remoting/host/security_key/security_key_extension.h View 3 chunks +8 lines, -8 lines 0 comments Download
A + remoting/host/security_key/security_key_extension.cc View 1 chunk +11 lines, -9 lines 0 comments Download
A + remoting/host/security_key/security_key_extension_session.h View 2 chunks +16 lines, -16 lines 0 comments Download
A + remoting/host/security_key/security_key_extension_session.cc View 10 chunks +29 lines, -28 lines 0 comments Download
A + remoting/host/security_key/security_key_extension_session_unittest.cc View 7 chunks +119 lines, -104 lines 0 comments Download
A + remoting/host/security_key/security_key_ipc_client.h View 3 chunks +9 lines, -9 lines 0 comments Download
A + remoting/host/security_key/security_key_ipc_client.cc View 10 chunks +19 lines, -20 lines 0 comments Download
A + remoting/host/security_key/security_key_ipc_client_unittest.cc View 7 chunks +82 lines, -93 lines 0 comments Download
A + remoting/host/security_key/security_key_ipc_constants.h View 2 chunks +8 lines, -8 lines 0 comments Download
A + remoting/host/security_key/security_key_ipc_constants.cc View 1 chunk +10 lines, -14 lines 0 comments Download
A + remoting/host/security_key/security_key_ipc_server.h View 3 chunks +17 lines, -17 lines 0 comments Download
A + remoting/host/security_key/security_key_ipc_server.cc View 2 chunks +9 lines, -9 lines 0 comments Download
A + remoting/host/security_key/security_key_ipc_server_impl.h View 3 chunks +14 lines, -15 lines 0 comments Download
A + remoting/host/security_key/security_key_ipc_server_impl.cc View 9 chunks +18 lines, -20 lines 0 comments Download
A + remoting/host/security_key/security_key_ipc_server_unittest.cc View 20 chunks +71 lines, -82 lines 0 comments Download
M remoting/host/security_key/security_key_message.h View 2 chunks +7 lines, -7 lines 0 comments Download
M remoting/host/security_key/security_key_message.cc View 3 chunks +15 lines, -16 lines 0 comments Download
A + remoting/host/security_key/security_key_message_handler.h View 2 chunks +27 lines, -28 lines 0 comments Download
A + remoting/host/security_key/security_key_message_handler.cc View 4 chunks +47 lines, -50 lines 0 comments Download
A + remoting/host/security_key/security_key_message_handler_unittest.cc View 9 chunks +81 lines, -84 lines 0 comments Download
A + remoting/host/security_key/security_key_message_reader.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + remoting/host/security_key/security_key_message_reader.cc View 6 chunks +15 lines, -17 lines 0 comments Download
A + remoting/host/security_key/security_key_message_reader_impl.h View 4 chunks +13 lines, -14 lines 0 comments Download
A + remoting/host/security_key/security_key_message_reader_impl.cc View 7 chunks +15 lines, -16 lines 0 comments Download
A + remoting/host/security_key/security_key_message_reader_impl_unittest.cc View 12 chunks +34 lines, -36 lines 0 comments Download
A remoting/host/security_key/security_key_message_writer.h View 1 chunk +30 lines, -0 lines 0 comments Download
A + remoting/host/security_key/security_key_message_writer.cc View 3 chunks +9 lines, -10 lines 0 comments Download
A + remoting/host/security_key/security_key_message_writer_impl.h View 2 chunks +12 lines, -13 lines 0 comments Download
A + remoting/host/security_key/security_key_message_writer_impl.cc View 3 chunks +9 lines, -10 lines 0 comments Download
A + remoting/host/security_key/security_key_message_writer_impl_unittest.cc View 10 chunks +28 lines, -30 lines 0 comments Download
A + remoting/host/security_key/security_key_socket.h View 4 chunks +10 lines, -10 lines 0 comments Download
A + remoting/host/security_key/security_key_socket.cc View 13 chunks +20 lines, -20 lines 0 comments Download
M remoting/remoting_host_srcs.gypi View 1 chunk +27 lines, -27 lines 0 comments Download
M remoting/remoting_test.gypi View 1 2 chunks +19 lines, -19 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
joedow
Relanding my refactoring from yesterday. The reason for the build break yesterday is that the ...
4 years, 5 months ago (2016-07-20 23:11:00 UTC) #6
Sergey Ulanov
lgtm
4 years, 5 months ago (2016-07-20 23:53:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164753004/20001
4 years, 5 months ago (2016-07-20 23:59:38 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 00:07:47 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 00:11:16 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e
Cr-Commit-Position: refs/heads/master@{#406718}

Powered by Google App Engine
This is Rietveld 408576698