Issue 2164753002: Reject deriveBits() for PBKDF2 when given a length of 0.

Issue 2164753002: Reject deriveBits() for PBKDF2 when given a length of 0. (Closed)

Created:
4 years, 5 months ago by eroman

Modified:
4 years, 5 months ago

Reviewers:
Ryan Sleevi

CC:
chromium-reviews, blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Reject deriveBits() for PBKDF2 when given a length of 0. BUG=534964 Committed: https://crrev.com/2d840b66726de648d943ab570ffe6d82236c4f0a Cr-Commit-Position: refs/heads/master@{#406393}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -35 lines)			Patch
M	components/webcrypto/algorithms/pbkdf2.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	components/webcrypto/status.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	components/webcrypto/status.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/crypto/subtle/pbkdf2/deriveBits.html	View	2 chunks	+0 lines, -14 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/crypto/subtle/pbkdf2/deriveBits-expected.txt	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/crypto/subtle/pbkdf2/deriveBits-failures.html	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/crypto/subtle/pbkdf2/deriveBits-failures-expected.txt	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/crypto/subtle/pbkdf2/deriveBits-rfc6070-test-vectors.html	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/crypto/subtle/pbkdf2/deriveBits-rfc6070-test-vectors-expected.txt	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 8 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164753002/1

4 years, 5 months ago (2016-07-19 19:18:41 UTC) #5

commit-bot: I haz the power

4 years, 5 months ago (2016-07-19 22:06:21 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2d840b66726de648d943ab570ffe6d82236c4f0a
Cr-Commit-Position: refs/heads/master@{#406393}