mash: Convert ash shelf overflow bubble to wm common types

mash: Convert ash shelf overflow bubble to wm common types

* Convert files to use WmShelf
* Eliminate ash::Shell and RootWindowController refs
* Move files to //ash/common

This allows a DEP on ShelfView as that class has dependencies back on the
overflow bubble and will need to move later.

No functional changes.

BUG=629248
TEST=ash_unittests, chrome unit_tests, manually open overflow bubble and quit
chrome, add secondary monitor, etc.

Committed: https://crrev.com/8a5416dc6f83c74fd820c44ace39154698b0648c
Cr-Commit-Position: refs/heads/master@{#406359}

[James Cook, 2016-07-19 18:26:08]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 18:26:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-07-19 18:26:34]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-07-19 18:26:35]

msw, please take a look.

[msw, 2016-07-19 19:14:08]

lgtm with minor nits.

https://codereview.chromium.org/2164733002/diff/1/ash/common/shelf/overflow_b...
File ash/common/shelf/overflow_button.h (right):

https://codereview.chromium.org/2164733002/diff/1/ash/common/shelf/overflow_b...
ash/common/shelf/overflow_button.h:8: #include "ash/common/shelf/shelf_types.h"
nit: not needed.

https://codereview.chromium.org/2164733002/diff/1/ash/common/shelf/wm_shelf.h
File ash/common/shelf/wm_shelf.h (right):

https://codereview.chromium.org/2164733002/diff/1/ash/common/shelf/wm_shelf.h...
ash/common/shelf/wm_shelf.h:49: // TODO(jamescook): Eliminate when ShelfView
moves to //ash/common.
nit: ditto comment for SchedulePaint()?

[James Cook, 2016-07-19 19:25:13]

https://codereview.chromium.org/2164733002/diff/1/ash/common/shelf/overflow_b...
File ash/common/shelf/overflow_button.h (right):

https://codereview.chromium.org/2164733002/diff/1/ash/common/shelf/overflow_b...
ash/common/shelf/overflow_button.h:8: #include "ash/common/shelf/shelf_types.h"
On 2016/07/19 19:14:07, msw wrote:
> nit: not needed.

Good catch. Done.

https://codereview.chromium.org/2164733002/diff/1/ash/common/shelf/wm_shelf.h
File ash/common/shelf/wm_shelf.h (right):

https://codereview.chromium.org/2164733002/diff/1/ash/common/shelf/wm_shelf.h...
ash/common/shelf/wm_shelf.h:49: // TODO(jamescook): Eliminate when ShelfView
moves to //ash/common.
On 2016/07/19 19:14:08, msw wrote:
> nit: ditto comment for SchedulePaint()?

Done.

[James Cook, 2016-07-19 19:25:22]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-07-19 19:25:23]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2164733002/#ps20001
(title: "review comments")

[commit-bot: I haz the power, 2016-07-19 19:25:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 20:04:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-19 20:07:53]

Description was changed from

==========
mash: Convert ash shelf overflow bubble to wm common types

* Convert files to use WmShelf
* Eliminate ash::Shell and RootWindowController refs
* Move files to //ash/common

This allows a DEP on ShelfView as that class has dependencies back on the
overflow bubble and will need to move later.

No functional changes.

BUG=629248
TEST=ash_unittests, chrome unit_tests, manually open overflow bubble and quit
chrome, add secondary monitor, etc.
==========

to

==========
mash: Convert ash shelf overflow bubble to wm common types

* Convert files to use WmShelf
* Eliminate ash::Shell and RootWindowController refs
* Move files to //ash/common

This allows a DEP on ShelfView as that class has dependencies back on the
overflow bubble and will need to move later.

No functional changes.

BUG=629248
TEST=ash_unittests, chrome unit_tests, manually open overflow bubble and quit
chrome, add secondary monitor, etc.

Committed: https://crrev.com/8a5416dc6f83c74fd820c44ace39154698b0648c
Cr-Commit-Position: refs/heads/master@{#406359}
==========

[commit-bot: I haz the power, 2016-07-19 20:07:55]

Patchset 2 (id:??) landed as
https://crrev.com/8a5416dc6f83c74fd820c44ace39154698b0648c
Cr-Commit-Position: refs/heads/master@{#406359}