Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 216473002: Replace DCHECK(BrowserThread::CurrentlyOn) with DCHECK_CURRENTLY_ON in content/browser/renderer_hos… (Closed)

Created:
6 years, 9 months ago by Jeffrey Yasskin
Modified:
6 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, nona+watch_chromium.org, fischman+watch_chromium.org, nasko+codewatch_chromium.org, jam, mcasas+watch_chromium.org, dcheng, penghuang+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, James Su, wjia+watch_chromium.org, yukishiino+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Replace DCHECK(BrowserThread::CurrentlyOn) with DCHECK_CURRENTLY_ON in content/browser/renderer_host. This is a follow-up to https://src.chromium.org/viewvc/chrome?revision=256913&view=revision that makes error messages more descriptive. It was automatically produced with git grep -l 'DCHECK(.*CurrentlyOn' content/browser/renderer_host/|xargs sed -i -e 's/DCHECK(BrowserThread::CurrentlyOn(\([^)]*\)))/DCHECK_CURRENTLY_ON(\1)/' -e 's/DCHECK(content::BrowserThread::CurrentlyOn(\([^)]*\)))/DCHECK_CURRENTLY_ON(\1)/' Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260340

Patch Set 1 #

Patch Set 2 : Sync #

Patch Set 3 : Sync to r260263 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -239 lines) Patch
M content/browser/renderer_host/clipboard_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/database_message_filter.cc View 1 12 chunks +13 lines, -13 lines 0 comments Download
M content/browser/renderer_host/gamepad_browser_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/gpu_message_filter.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M content/browser/renderer_host/ime_adapter_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/java/java_bridge_dispatcher_host_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_device_manager.cc View 9 chunks +10 lines, -10 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host.cc View 13 chunks +13 lines, -13 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M content/browser/renderer_host/media/device_request_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/media_capture_devices_impl.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 1 2 29 chunks +32 lines, -32 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_ui_proxy.cc View 10 chunks +13 lines, -13 lines 0 comments Download
M content/browser/renderer_host/media/midi_dispatcher_host.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host.cc View 14 chunks +14 lines, -14 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.cc View 15 chunks +15 lines, -15 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_file_io_host.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_host_resolver_message_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_network_monitor_host.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_network_proxy_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_print_settings_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_renderer_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_socket_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_tcp_socket.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc View 22 chunks +22 lines, -22 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_helper.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/socket_stream_dispatcher_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Jeffrey Yasskin
jam suggested I TBR these CLs, but I'm sending the first couple to owners as ...
6 years, 9 months ago (2014-03-28 06:19:59 UTC) #1
sky
I looked at the first couple files and then my eyes glazed over. Rubber stamp ...
6 years, 9 months ago (2014-03-28 15:48:19 UTC) #2
Jeffrey Yasskin
The CQ bit was checked by jyasskin@chromium.org
6 years, 9 months ago (2014-03-28 15:51:45 UTC) #3
Jeffrey Yasskin
On 2014/03/28 15:48:19, sky wrote: > I looked at the first couple files and then ...
6 years, 9 months ago (2014-03-28 15:52:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/216473002/20001
6 years, 9 months ago (2014-03-28 15:53:46 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 16:35:27 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 9 months ago (2014-03-28 16:35:27 UTC) #7
Jeffrey Yasskin
The CQ bit was checked by jyasskin@chromium.org
6 years, 9 months ago (2014-03-28 19:37:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/216473002/20001
6 years, 9 months ago (2014-03-28 19:37:35 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 21:11:20 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 9 months ago (2014-03-28 21:11:21 UTC) #11
Jeffrey Yasskin
The CQ bit was checked by jyasskin@chromium.org
6 years, 9 months ago (2014-03-28 21:43:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/216473002/30001
6 years, 9 months ago (2014-03-28 21:48:15 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-29 00:16:14 UTC) #14
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-29 00:16:14 UTC) #15
Jeffrey Yasskin
The CQ bit was checked by jyasskin@chromium.org
6 years, 9 months ago (2014-03-29 00:44:12 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/216473002/30001
6 years, 9 months ago (2014-03-29 00:45:00 UTC) #17
commit-bot: I haz the power
6 years, 9 months ago (2014-03-29 02:01:30 UTC) #18
Message was sent while issue was closed.
Change committed as 260340

Powered by Google App Engine
This is Rietveld 408576698