Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: gpu/command_buffer/tests/gl_bgra_mipmap_unittest.cc

Issue 2164723003: Fix gpu mipmap support on ChromeOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: restrict fix to ES3 Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gpu/BUILD.gn ('k') | gpu/gpu.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include <GLES2/gl2.h>
6 #include <GLES2/gl2ext.h>
7 #include <stdint.h>
8
9 #include "gpu/command_buffer/tests/gl_manager.h"
10 #include "gpu/command_buffer/tests/gl_test_utils.h"
11 #include "testing/gtest/include/gtest/gtest.h"
12
13 namespace gpu {
14
15 // A collection of tests that exercise the GL_EXT_srgb extension.
16 class GLBGRAMipMapTest : public testing::Test {
17 protected:
18 void SetUp() override { gl_.Initialize(GLManager::Options()); }
19 void TearDown() override { gl_.Destroy(); }
20 GLManager gl_;
21 };
22
23 // Test to ensure that using GL_BGRA as a texture internal format does
24 // not hinder the use of mipmaps. Support for GL_BGRA as an internal format
25 // is required by ES 2.0 (internal format must be equal to external format),
26 // but some desktop GL implementations may not fully support the use of
27 // GL_BGRA. For example, Mesa+Intel does not support mipmapping on textures
28 // that use the GL_BGRA internal format. This test verifies a workaround.
29 TEST_F(GLBGRAMipMapTest, GenerateMipmapsSucceeds) {
30 static const int kWidth = 100;
31 static const int kHeight = 50;
32
33 uint8_t pixels[kWidth * kHeight * 4];
34
35 GLuint tex = 0;
36 glGenTextures(1, &tex);
37 glBindTexture(GL_TEXTURE_2D, tex);
38
39 memset(pixels, 128, sizeof(pixels));
40 glTexImage2D(GL_TEXTURE_2D, 0, GL_BGRA_EXT, kWidth, kHeight, 0,
41 GL_BGRA_EXT, GL_UNSIGNED_BYTE, pixels);
42 EXPECT_EQ(static_cast<GLenum>(GL_NO_ERROR), glGetError());
43
44 // Without the workaround, the following call generates a
45 // GL_INVALID_OPERATION error on some desktop GL implementations
46 glGenerateMipmap(GL_TEXTURE_2D);
47 EXPECT_EQ(static_cast<GLenum>(GL_NO_ERROR), glGetError());
48 }
49
50 } // namespace gpu
OLDNEW
« no previous file with comments | « gpu/BUILD.gn ('k') | gpu/gpu.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698