chrome/browser/ui/cocoa/download/download_item_controller.mm - Issue 2164723002: Change Dismiss button to Discard and cancel download

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/download/download_item_controller.mm

Issue 2164723002: Change Dismiss button to Discard and cancel download (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove IDS_DISMISS_DOWNLOAD from generated_resources.grd Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/download/download_item_controller.h ('k') | chrome/browser/ui/views/download/download_item_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/download/download_item_controller.mm

diff --git a/chrome/browser/ui/cocoa/download/download_item_controller.mm b/chrome/browser/ui/cocoa/download/download_item_controller.mm

index 0298199d9d9e8fa5006cb487f4b149ce2261cc49..fd3a5f8628ac27e4eeedf642a1118e4c3c3add0c 100644

--- a/chrome/browser/ui/cocoa/download/download_item_controller.mm

+++ b/chrome/browser/ui/cocoa/download/download_item_controller.mm

@@ -362,13 +362,6 @@ class DownloadShelfContextMenuMac : public DownloadShelfContextMenu {

// WARNING: we are deleted at this point. Don't access 'this'.

}

-- (IBAction)dismissMaliciousDownload:(id)sender {

- // ExperienceSampling: User dismissed the dangerous download.

- [self updateExperienceSamplingEvent:ExperienceSamplingEvent::kDeny];

- [self remove];

- // WARNING: we are deleted at this point.

- (IBAction)showContextMenu:(id)sender {

[progressView_ showContextMenu];

}