Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: runtime/vm/isolate.h

Issue 2164703003: Fix for use-after-free of reload context (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: s/test_mode/dont_delete_reload_context/, simplifications Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.h
diff --git a/runtime/vm/isolate.h b/runtime/vm/isolate.h
index a43a543cfc2312246af5cfac6cb1cc10490398a9..b49d59b130bf265f9f316dee4d2d03b39ab94e08 100644
--- a/runtime/vm/isolate.h
+++ b/runtime/vm/isolate.h
@@ -255,7 +255,9 @@ class Isolate : public BaseIsolate {
void DoneLoading();
void DoneFinalizing();
- void ReloadSources(bool test_mode = false);
+ // By default the reload context is deleted. This parameter allows
+ // the caller to delete is separately if it is still needed.
+ void ReloadSources(bool dont_delete_reload_context = false);
bool MakeRunnable();
void Run();
@@ -480,6 +482,8 @@ class Isolate : public BaseIsolate {
return reload_context_;
}
+ void DeleteReloadContext();
+
bool HasAttemptedReload() const {
return has_attempted_reload_;
}
« no previous file with comments | « no previous file | runtime/vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698