Fix for use-after-free of reload context

runtime/vm/isolate_reload.h

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_ISOLATE_RELOAD_H_
 #define VM_ISOLATE_RELOAD_H_
 
 #include "vm/globals.h"
 #include "vm/growable_array.h"
 #include "vm/log.h"
@@ skipping 28 matching lines @@
 class RawGrowableObjectArray;
 class RawLibrary;
 class RawObject;
 class RawString;
 class ObjectPointerVisitor;
 class ObjectStore;
 class UpdateClassesVisitor;
 
 class IsolateReloadContext {
  public:
-  explicit IsolateReloadContext(Isolate* isolate, bool test_mode = false);
+  explicit IsolateReloadContext(Isolate* isolate);
   ~IsolateReloadContext();
 
   void StartReload();
   void FinishReload();
   void AbortReload(const Error& error);
 
   RawLibrary* saved_root_library() const;
 
   RawGrowableObjectArray* saved_libraries() const;
 
   void ReportError(const Error& error);
   void ReportError(const String& error_msg);
   void ReportSuccess();
 
   bool has_error() const { return has_error_; }
   RawError* error() const { return error_; }
-  bool test_mode() const { return test_mode_; }
 
   static bool IsSameField(const Field& a, const Field& b);
   static bool IsSameLibrary(const Library& a_lib, const Library& b_lib);
   static bool IsSameClass(const Class& a, const Class& b);
 
   RawClass* FindOriginalClass(const Class& cls);
 
   bool IsDirty(const Library& lib);
 
   // Prefers old classes when we are in the middle of a reload.
@@ skipping 46 matching lines @@
   void ClearReplacedObjectBits();
 
   // atomic_install:
   void MarkAllFunctionsForRecompilation();
   void ResetUnoptimizedICsOnStack();
   void ResetMegamorphicCaches();
   void InvalidateWorld();
 
   int64_t start_time_micros_;
   Isolate* isolate_;
-  bool test_mode_;
   bool has_error_;
 
   intptr_t saved_num_cids_;
   RawClass** saved_class_table_;
 
   intptr_t num_saved_libs_;
   struct LibraryInfo {
     bool dirty;
   };
   MallocGrowableArray<LibraryInfo> library_infos_;
@@ skipping 32 matching lines @@
   RawGrowableObjectArray* saved_libraries_;
   RawObject** to() { return reinterpret_cast<RawObject**>(&saved_libraries_); }
 
   friend class Isolate;
   friend class Class;  // AddStaticFieldMapping, AddEnumBecomeMapping.
 };
 
 }  // namespace dart
 
 #endif   // VM_ISOLATE_RELOAD_H_