Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1260)

Issue 2164633005: Convert source sets to static libraries. (Closed)

Created:
4 years, 2 months ago by brettw
Modified:
4 years, 2 months ago
Reviewers:
jam
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Convert source sets to static libraries. This improves build performance somewhat. This does not change the standalone targets since these don't affect the build time of Chrome and are small enough for it not to matter anyway. BUG=http://crbug.com/627637 Committed: https://pdfium.googlesource.com/pdfium/+/e283e47aa3e6786dad94392db292e08ce18ccd5e

Patch Set 1 #

Patch Set 2 : base #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/BUILD.gn View 1 9 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
brettw
4 years, 2 months ago (2016-07-20 21:09:48 UTC) #2
brettw
base
4 years, 2 months ago (2016-07-20 21:24:48 UTC) #7
jam
lgtm
4 years, 2 months ago (2016-07-21 16:14:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164633005/20001
4 years, 2 months ago (2016-07-21 16:38:08 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-07-21 16:38:27 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/e283e47aa3e6786dad94392db292e08ce18c...

Powered by Google App Engine
This is Rietveld 408576698