Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2164633004: Enable ui_struct_traits_unittests on try bots. (Closed)

Created:
4 years, 5 months ago by kylechar
Modified:
4 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@display_traits
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable ui_struct_traits_unittests on trybots. Add to linux, chromeos and windows trybots. BUG=none Committed: https://crrev.com/89355878d1d8c4b3ece05d3a48070f87de4e5384 Cr-Commit-Position: refs/heads/master@{#409236}

Patch Set 1 #

Patch Set 2 : Fix typo. #

Patch Set 3 : Add to Chrome OS. #

Patch Set 4 : Ozone bot for real this time. #

Patch Set 5 : Add testonly. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M services/ui/public/interfaces/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 1 2 3 2 chunks +12 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
kylechar
Hey sky, I tried to pick a representative set of bots that made sense here. ...
4 years, 4 months ago (2016-07-28 15:31:57 UTC) #3
sky
Sure, LGTM
4 years, 4 months ago (2016-08-01 21:41:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164633004/80001
4 years, 4 months ago (2016-08-02 16:49:10 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-02 18:00:13 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 18:02:17 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/89355878d1d8c4b3ece05d3a48070f87de4e5384
Cr-Commit-Position: refs/heads/master@{#409236}

Powered by Google App Engine
This is Rietveld 408576698