Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: src/arguments.h

Issue 2164633002: [runtime] temporarily transform IsContext check from DHECK to CHECK (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: adding todo Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/builtins/builtins-utils.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_ARGUMENTS_H_ 5 #ifndef V8_ARGUMENTS_H_
6 #define V8_ARGUMENTS_H_ 6 #define V8_ARGUMENTS_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/objects-inl.h" 9 #include "src/objects-inl.h"
10 #include "src/tracing/trace-event.h" 10 #include "src/tracing/trace-event.h"
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 double ClobberDoubleRegisters(double x1, double x2, double x3, double x4); 74 double ClobberDoubleRegisters(double x1, double x2, double x3, double x4);
75 75
76 #ifdef DEBUG 76 #ifdef DEBUG
77 #define CLOBBER_DOUBLE_REGISTERS() ClobberDoubleRegisters(1, 2, 3, 4); 77 #define CLOBBER_DOUBLE_REGISTERS() ClobberDoubleRegisters(1, 2, 3, 4);
78 #else 78 #else
79 #define CLOBBER_DOUBLE_REGISTERS() 79 #define CLOBBER_DOUBLE_REGISTERS()
80 #endif 80 #endif
81 81
82 // TODO(cbruni): add global flag to check whether any tracing events have been 82 // TODO(cbruni): add global flag to check whether any tracing events have been
83 // enabled. 83 // enabled.
84 // TODO(cbruni): Convert the IsContext CHECK back to a DCHECK.
84 #define RUNTIME_FUNCTION_RETURNS_TYPE(Type, Name) \ 85 #define RUNTIME_FUNCTION_RETURNS_TYPE(Type, Name) \
85 static INLINE(Type __RT_impl_##Name(Arguments args, Isolate* isolate)); \ 86 static INLINE(Type __RT_impl_##Name(Arguments args, Isolate* isolate)); \
86 \ 87 \
87 V8_NOINLINE static Type Stats_##Name(int args_length, Object** args_object, \ 88 V8_NOINLINE static Type Stats_##Name(int args_length, Object** args_object, \
88 Isolate* isolate) { \ 89 Isolate* isolate) { \
89 RuntimeCallTimerScope timer(isolate, &RuntimeCallStats::Name); \ 90 RuntimeCallTimerScope timer(isolate, &RuntimeCallStats::Name); \
90 TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8.runtime"), \ 91 TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8.runtime"), \
91 "V8.Runtime_" #Name); \ 92 "V8.Runtime_" #Name); \
92 Arguments args(args_length, args_object); \ 93 Arguments args(args_length, args_object); \
93 return __RT_impl_##Name(args, isolate); \ 94 return __RT_impl_##Name(args, isolate); \
94 } \ 95 } \
95 \ 96 \
96 Type Name(int args_length, Object** args_object, Isolate* isolate) { \ 97 Type Name(int args_length, Object** args_object, Isolate* isolate) { \
97 DCHECK(isolate->context() == nullptr || isolate->context()->IsContext()); \ 98 CHECK(isolate->context() == nullptr || isolate->context()->IsContext()); \
98 CLOBBER_DOUBLE_REGISTERS(); \ 99 CLOBBER_DOUBLE_REGISTERS(); \
99 if (FLAG_runtime_call_stats) { \ 100 if (FLAG_runtime_call_stats) { \
100 return Stats_##Name(args_length, args_object, isolate); \ 101 return Stats_##Name(args_length, args_object, isolate); \
101 } \ 102 } \
102 Arguments args(args_length, args_object); \ 103 Arguments args(args_length, args_object); \
103 return __RT_impl_##Name(args, isolate); \ 104 return __RT_impl_##Name(args, isolate); \
104 } \ 105 } \
105 \ 106 \
106 static Type __RT_impl_##Name(Arguments args, Isolate* isolate) 107 static Type __RT_impl_##Name(Arguments args, Isolate* isolate)
107 108
108 #define RUNTIME_FUNCTION(Name) RUNTIME_FUNCTION_RETURNS_TYPE(Object*, Name) 109 #define RUNTIME_FUNCTION(Name) RUNTIME_FUNCTION_RETURNS_TYPE(Object*, Name)
109 #define RUNTIME_FUNCTION_RETURN_PAIR(Name) \ 110 #define RUNTIME_FUNCTION_RETURN_PAIR(Name) \
110 RUNTIME_FUNCTION_RETURNS_TYPE(ObjectPair, Name) 111 RUNTIME_FUNCTION_RETURNS_TYPE(ObjectPair, Name)
111 #define RUNTIME_FUNCTION_RETURN_TRIPLE(Name) \ 112 #define RUNTIME_FUNCTION_RETURN_TRIPLE(Name) \
112 RUNTIME_FUNCTION_RETURNS_TYPE(ObjectTriple, Name) 113 RUNTIME_FUNCTION_RETURNS_TYPE(ObjectTriple, Name)
113 114
114 } // namespace internal 115 } // namespace internal
115 } // namespace v8 116 } // namespace v8
116 117
117 #endif // V8_ARGUMENTS_H_ 118 #endif // V8_ARGUMENTS_H_
OLDNEW
« no previous file with comments | « no previous file | src/builtins/builtins-utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698