Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1866)

Unified Diff: Source/core/svg/SVGElement.cpp

Issue 216463003: Allow <use> inside author shadow roots (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove loop in isInUserAgentShadowTree, add a title test Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/svg/dom/use-in-shadow-tree-expected.html ('k') | Source/core/svg/SVGUseElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGElement.cpp
diff --git a/Source/core/svg/SVGElement.cpp b/Source/core/svg/SVGElement.cpp
index 1e9e5b0f3676a563c08b6c5956ece3cf10093e87..fdfd69b08660c578cce3ca5d218f0c6adb573abf 100644
--- a/Source/core/svg/SVGElement.cpp
+++ b/Source/core/svg/SVGElement.cpp
@@ -236,10 +236,6 @@ String SVGElement::title() const
// Walk up the tree, to find out whether we're inside a <use> shadow tree, to find the right title.
if (isInShadowTree()) {
Element* shadowHostElement = toShadowRoot(treeScope().rootNode()).host();
- // At this time, SVG nodes are not allowed in non-<use> shadow trees, so any shadow root we do
- // have should be a use. The assert and following test is here to catch future shadow DOM changes
- // that do enable SVG in a shadow tree.
- ASSERT(!shadowHostElement || isSVGUseElement(*shadowHostElement));
if (isSVGUseElement(shadowHostElement)) {
SVGUseElement& useElement = toSVGUseElement(*shadowHostElement);
« no previous file with comments | « LayoutTests/svg/dom/use-in-shadow-tree-expected.html ('k') | Source/core/svg/SVGUseElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698