Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2164603004: Cleaned up variables layout test (Closed)

Created:
4 years, 5 months ago by sashab
Modified:
4 years, 5 months ago
Reviewers:
meade_UTC10
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleaned up variables layout test Cleaned up a variables layout test, fast/css/variables/recompute-variables-when-parent-style-updates.html, to use better names and be better self-documenting. Committed: https://crrev.com/a349aa861d9cca416f2b624e80b779f5ae4dce14 Cr-Commit-Position: refs/heads/master@{#406494}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -24 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/variables/recompute-variables-when-parent-style-updates.html View 1 chunk +25 lines, -24 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sashab
4 years, 5 months ago (2016-07-20 03:08:55 UTC) #2
sashab
4 years, 5 months ago (2016-07-20 03:09:10 UTC) #4
meade_UTC10
lgtm
4 years, 5 months ago (2016-07-20 03:12:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164603004/1
4 years, 5 months ago (2016-07-20 03:13:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 04:37:37 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 04:37:39 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 04:39:41 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a349aa861d9cca416f2b624e80b779f5ae4dce14
Cr-Commit-Position: refs/heads/master@{#406494}

Powered by Google App Engine
This is Rietveld 408576698