Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5155)

Unified Diff: chrome/browser/extensions/activity_log/fullstream_ui_policy.h

Issue 21646004: Compressed activity log database storage (Closed) Base URL: http://git.chromium.org/chromium/src.git@refactor-cleanups
Patch Set: Factor out dropping of obsolete tables and use in all policies Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/fullstream_ui_policy.h
diff --git a/chrome/browser/extensions/activity_log/fullstream_ui_policy.h b/chrome/browser/extensions/activity_log/fullstream_ui_policy.h
index 49a8b700c8fe1d8286157c648419aae2cc55a8fc..4f50d54cf8e36667a808f7d260f6b79ed35cd526 100644
--- a/chrome/browser/extensions/activity_log/fullstream_ui_policy.h
+++ b/chrome/browser/extensions/activity_log/fullstream_ui_policy.h
@@ -16,6 +16,11 @@ namespace extensions {
// A policy for logging the full stream of actions, including all arguments.
// It's mostly intended to be used in testing and analysis.
+//
+// NOTE: The FullStreamUIPolicy deliberately keeps almost all information,
+// including some data that could be privacy sensitive (full URLs including
+// incognito URLs, full headers when WebRequest is used, etc.). It should not
+// be used during normal browsing if users care about privacy.
class FullStreamUIPolicy : public ActivityLogDatabasePolicy {
public:
// For more info about these member functions, see the super class.
@@ -34,9 +39,6 @@ class FullStreamUIPolicy : public ActivityLogDatabasePolicy {
const base::Callback
<void(scoped_ptr<Action::ActionVector>)>& callback) OVERRIDE;
- // Returns the actual key for a given key type
- virtual std::string GetKey(ActivityLogPolicy::KeyType key_id) const OVERRIDE;
-
virtual void Close() OVERRIDE;
// Database table schema.
@@ -50,8 +52,8 @@ class FullStreamUIPolicy : public ActivityLogDatabasePolicy {
// ActivityDatabase class for an overall discussion of how cleanup works.
virtual ~FullStreamUIPolicy();
- // The ActivityDatabase::PolicyDelegate interface. These are always called
- // from the database thread.
+ // The ActivityDatabase::Delegate interface. These are always called from
+ // the database thread.
virtual bool InitDatabase(sql::Connection* db) OVERRIDE;
virtual bool FlushDatabase(sql::Connection* db) OVERRIDE;
virtual void OnDatabaseFailure() OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698