Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2164583002: Reland "[interpeter] Move to table based peephole optimizer." (Closed)

Created:
4 years, 5 months ago by oth
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, rmcilroy, Michael Achenbach
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[interpeter] Move to table based peephole optimizer." Original issue's description: > [interpeter] Move to table based peephole optimizer. > > Introduces a lookup table for peephole optimizations. > > Fixes some tests using BytecodePeepholeOptimizer::Write() that should > have been update to use BytecodePeepholeOptimizer::WriteJump(). > > BUG=v8:4280 > LOG=N > > Committed: https://crrev.com/f4234422b93b21a286b0f31799009bcbe8b90b9e > Cr-Commit-Position: refs/heads/master@{#37819} BUG=v8:4280 LOG=N Committed: https://crrev.com/a451bd1a687987a7056d7847ba14aefd195dd760 Cr-Commit-Position: refs/heads/master@{#37866}

Patch Set 1 #

Patch Set 2 : Nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+799 lines, -271 lines) Patch
M BUILD.gn View 5 chunks +49 lines, -0 lines 0 comments Download
M gypfiles/standalone.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/bytecode-peephole-optimizer.h View 3 chunks +13 lines, -16 lines 0 comments Download
M src/interpreter/bytecode-peephole-optimizer.cc View 7 chunks +212 lines, -221 lines 0 comments Download
A src/interpreter/bytecode-peephole-table.h View 1 chunk +73 lines, -0 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/interpreter/bytecodes.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A src/interpreter/mkpeephole.cc View 1 chunk +387 lines, -0 lines 0 comments Download
M src/v8.gyp View 4 chunks +41 lines, -0 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ConstVariable.golden View 2 chunks +1 line, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/LetVariable.golden View 2 chunks +1 line, -2 lines 0 comments Download
M test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc View 6 chunks +13 lines, -22 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
oth
Ross, PTAL. The only delta in the reland is the change to gypfiles/standalone.gypi. It now ...
4 years, 5 months ago (2016-07-19 10:41:48 UTC) #4
rmcilroy
lgtm
4 years, 5 months ago (2016-07-19 11:13:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164583002/10001
4 years, 5 months ago (2016-07-19 11:18:07 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:10001)
4 years, 5 months ago (2016-07-19 11:54:27 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 11:54:29 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a451bd1a687987a7056d7847ba14aefd195dd760 Cr-Commit-Position: refs/heads/master@{#37866}
4 years, 5 months ago (2016-07-19 11:56:43 UTC) #11
akos.palfi.imgtec
@oth: It seems the change in standalone.gypi breaks the mips (big-endian) build when snapshot is ...
4 years, 5 months ago (2016-07-21 16:52:52 UTC) #13
oth
4 years, 5 months ago (2016-07-22 08:51:28 UTC) #14
Message was sent while issue was closed.
On 2016/07/21 16:52:52, akos.palfi.imgtec wrote:
> @oth:
> It seems the change in standalone.gypi breaks the mips (big-endian) build when
> snapshot is enabled. On big-endian mips we build the mksnapshot for the target
> and execute it on qemu (since we haven't implemented big-endian simulator) to
> generate the snapshot. With your change now it is built for host which is
> little-endian and thus the generated snapshot can't be loaded.
> 
> I've uploaded a CL which reverts the gyp change, PTAL:
> https://codereview.chromium.org/2172653002

@rmcilroy, jfyi, response on the proposed CL:
https://codereview.chromium.org/2172653002

Powered by Google App Engine
This is Rietveld 408576698