Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: chrome/browser/safe_browsing/permission_reporter_browsertest.cc

Issue 2164513002: Add browsertest for permission action reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-hooks-to-permission-layer2
Patch Set: Remove android tests + Move MockReportSender to separate file Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/permission_reporter_browsertest.cc
diff --git a/chrome/browser/safe_browsing/permission_reporter_browsertest.cc b/chrome/browser/safe_browsing/permission_reporter_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..0db47067cf4ebc78c1d23ad648c49a0e30533356
--- /dev/null
+++ b/chrome/browser/safe_browsing/permission_reporter_browsertest.cc
@@ -0,0 +1,127 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/safe_browsing/permission_reporter.h"
+
+#include "base/command_line.h"
+#include "base/memory/ptr_util.h"
+#include "base/memory/ref_counted.h"
+#include "base/test/simple_test_clock.h"
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/permissions/permission_request_manager.h"
+#include "chrome/browser/safe_browsing/mock_report_sender.h"
+#include "chrome/browser/safe_browsing/ping_manager.h"
+#include "chrome/browser/safe_browsing/safe_browsing_service.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/browser/ui/website_settings/mock_permission_bubble_factory.h"
+#include "chrome/common/chrome_switches.h"
+#include "chrome/common/safe_browsing/permission_report.pb.h"
+#include "chrome/test/base/in_process_browser_test.h"
+#include "chrome/test/base/ui_test_utils.h"
+#include "content/public/browser/browser_thread.h"
+
+#if !defined(OS_CHROMEOS)
+#include "chrome/browser/signin/signin_manager_factory.h"
+#include "components/signin/core/browser/signin_manager.h"
+#endif
+
+namespace safe_browsing {
+
+class PermissionReporterBrowserTest : public InProcessBrowserTest {
+ protected:
+ void SetUpOnMainThread() override {
+ InProcessBrowserTest::SetUpOnMainThread();
+
+ base::RunLoop run_loop;
+ content::BrowserThread::PostTaskAndReply(
+ content::BrowserThread::IO, FROM_HERE,
+ base::Bind(
+ &PermissionReporterBrowserTest::AttachMockReportSenderOnIOThread,
+ this,
+ make_scoped_refptr(g_browser_process->safe_browsing_service())),
+ run_loop.QuitClosure());
+ run_loop.Run();
+
+ PermissionRequestManager* manager = GetPermissionRequestManager();
+ mock_permission_bubble_factory_.reset(
+ new MockPermissionBubbleFactory(manager));
+ manager->DisplayPendingRequests();
+
+#if !defined(OS_CHROMEOS)
+ SigninManager* signin_manager =
+ SigninManagerFactory::GetForProfile(browser()->profile());
+ signin_manager->SetAuthenticatedAccountInfo("gaia_id", "fake_username");
+#endif
+ }
+
+ void TearDownOnMainThread() override {
+ InProcessBrowserTest::TearDownOnMainThread();
+ mock_permission_bubble_factory_.reset();
+ }
+
+ void SetUpCommandLine(base::CommandLine* command_line) override {
+ command_line->AppendSwitch(switches::kEnablePermissionActionReporting);
+ }
+
+ void AttachMockReportSenderOnIOThread(
+ scoped_refptr<SafeBrowsingService> safe_browsing_service) {
+ DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
+
+ mock_report_sender_ = new MockReportSender;
+
+ safe_browsing_service->ping_manager()->permission_reporter_.reset(
+ new PermissionReporter(base::WrapUnique(mock_report_sender_),
+ base::WrapUnique(new base::SimpleTestClock)));
+ }
+
+ PermissionRequestManager* GetPermissionRequestManager() {
+ return PermissionRequestManager::FromWebContents(
+ browser()->tab_strip_model()->GetActiveWebContents());
+ }
+
+ void AcceptBubble() { GetPermissionRequestManager()->Accept(); }
raymes 2016/07/26 07:42:06 nit: probably just inline this
stefanocs 2016/07/26 11:17:37 Done.
stefanocs 2016/07/27 04:11:19 I changed this back. This cannot be inlined becaus
+
+ MockPermissionBubbleFactory* bubble_factory() {
+ return mock_permission_bubble_factory_.get();
+ }
+
+ MockReportSender* mock_report_sender() { return mock_report_sender_; }
+
+ private:
+ std::unique_ptr<MockPermissionBubbleFactory> mock_permission_bubble_factory_;
+
+ // Owned by permission reporter.
+ MockReportSender* mock_report_sender_;
+};
+
+// Test that permission action report will be sent if the user is opted into it.
+IN_PROC_BROWSER_TEST_F(PermissionReporterBrowserTest,
+ PermissionActionReporting) {
+ ASSERT_TRUE(embedded_test_server()->Start());
+
+ ui_test_utils::NavigateToURLBlockUntilNavigationsComplete(
+ browser(), embedded_test_server()->GetURL("/permissions/request.html"),
+ 1);
+
+ bubble_factory()->WaitForPermissionBubble();
+ EXPECT_TRUE(bubble_factory()->is_visible());
+
+ AcceptBubble();
+
+ EXPECT_FALSE(bubble_factory()->is_visible());
+ EXPECT_EQ(1, mock_report_sender()->GetAndResetNumberOfReportsSent());
+
+ PermissionReport permission_report;
+ ASSERT_TRUE(
+ permission_report.ParseFromString(mock_report_sender()->latest_report()));
+ EXPECT_EQ(PermissionReport::GEOLOCATION, permission_report.permission());
+ EXPECT_EQ(PermissionReport::GRANTED, permission_report.action());
+ EXPECT_EQ(embedded_test_server()->base_url().spec(),
+ permission_report.origin());
+ EXPECT_EQ(PermissionReport::DESKTOP_PLATFORM,
+ permission_report.platform_type());
+}
+
+} // namespace safe_browsing

Powered by Google App Engine
This is Rietveld 408576698