Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: chrome/browser/safe_browsing/permission_reporter_unittest.cc

Issue 2164513002: Add browsertest for permission action reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-hooks-to-permission-layer2
Patch Set: Remove android tests + Move MockReportSender to separate file Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/safe_browsing/permission_reporter.h" 5 #include "chrome/browser/safe_browsing/permission_reporter.h"
6 6
7 #include "base/feature_list.h" 7 #include "base/feature_list.h"
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "base/metrics/field_trial.h" 9 #include "base/metrics/field_trial.h"
10 #include "base/test/simple_test_clock.h" 10 #include "base/test/simple_test_clock.h"
11 #include "base/time/time.h" 11 #include "base/time/time.h"
12 #include "chrome/browser/safe_browsing/mock_report_sender.h"
12 #include "chrome/common/safe_browsing/permission_report.pb.h" 13 #include "chrome/common/safe_browsing/permission_report.pb.h"
13 #include "components/variations/active_field_trials.h" 14 #include "components/variations/active_field_trials.h"
14 #include "content/public/browser/permission_type.h" 15 #include "content/public/browser/permission_type.h"
15 #include "net/url_request/report_sender.h"
16 #include "testing/gtest/include/gtest/gtest.h" 16 #include "testing/gtest/include/gtest/gtest.h"
17 17
18 using content::PermissionType; 18 using content::PermissionType;
19 19
20 namespace safe_browsing { 20 namespace safe_browsing {
21 21
22 namespace { 22 namespace {
23 23
24 // URL to upload permission action reports. 24 // URL to upload permission action reports.
25 const char kPermissionActionReportingUploadUrl[] = 25 const char kPermissionActionReportingUploadUrl[] =
(...skipping 17 matching lines...) Expand all
43 const char kFeatureOnByDefaultName[] = "OnByDefault"; 43 const char kFeatureOnByDefaultName[] = "OnByDefault";
44 struct base::Feature kFeatureOnByDefault { 44 struct base::Feature kFeatureOnByDefault {
45 kFeatureOnByDefaultName, base::FEATURE_ENABLED_BY_DEFAULT 45 kFeatureOnByDefaultName, base::FEATURE_ENABLED_BY_DEFAULT
46 }; 46 };
47 47
48 const char kFeatureOffByDefaultName[] = "OffByDefault"; 48 const char kFeatureOffByDefaultName[] = "OffByDefault";
49 struct base::Feature kFeatureOffByDefault { 49 struct base::Feature kFeatureOffByDefault {
50 kFeatureOffByDefaultName, base::FEATURE_DISABLED_BY_DEFAULT 50 kFeatureOffByDefaultName, base::FEATURE_DISABLED_BY_DEFAULT
51 }; 51 };
52 52
53 // A mock ReportSender that keeps track of the last report sent.
54 class MockReportSender : public net::ReportSender {
55 public:
56 MockReportSender() : net::ReportSender(nullptr, DO_NOT_SEND_COOKIES) {
57 number_of_reports_ = 0;
58 }
59
60 ~MockReportSender() override {}
61
62 void Send(const GURL& report_uri, const std::string& report) override {
63 latest_report_uri_ = report_uri;
64 latest_report_ = report;
65 number_of_reports_++;
66 }
67
68 const GURL& latest_report_uri() { return latest_report_uri_; }
69
70 const std::string& latest_report() { return latest_report_; }
71
72 int GetAndResetNumberOfReportsSent() {
73 int new_reports = number_of_reports_;
74 number_of_reports_ = 0;
75 return new_reports;
76 }
77
78 private:
79 GURL latest_report_uri_;
80 std::string latest_report_;
81 int number_of_reports_;
82
83 DISALLOW_COPY_AND_ASSIGN(MockReportSender);
84 };
85
86 } // namespace 53 } // namespace
87 54
88 class PermissionReporterTest : public ::testing::Test { 55 class PermissionReporterTest : public ::testing::Test {
89 protected: 56 protected:
90 void SetUp() override { 57 void SetUp() override {
91 mock_report_sender_ = new MockReportSender; 58 mock_report_sender_ = new MockReportSender;
92 clock_ = new base::SimpleTestClock; 59 clock_ = new base::SimpleTestClock;
93 permission_reporter_.reset(new PermissionReporter( 60 permission_reporter_.reset(new PermissionReporter(
94 base::WrapUnique(mock_report_sender_), base::WrapUnique(clock_))); 61 base::WrapUnique(mock_report_sender_), base::WrapUnique(clock_)));
95 } 62 }
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 clock_->Advance(base::TimeDelta::FromSeconds(5)); 214 clock_->Advance(base::TimeDelta::FromSeconds(5));
248 permission_reporter_->SendReport(GURL(kDummyOriginOne), kDummyPermissionOne, 215 permission_reporter_->SendReport(GURL(kDummyOriginOne), kDummyPermissionOne,
249 kDummyAction, kDummySourceUI, 216 kDummyAction, kDummySourceUI,
250 false /* user_gesture */); 217 false /* user_gesture */);
251 } 218 }
252 EXPECT_EQ(kMaximumReportsPerOriginPerPermissionPerMinute, 219 EXPECT_EQ(kMaximumReportsPerOriginPerPermissionPerMinute,
253 mock_report_sender_->GetAndResetNumberOfReportsSent()); 220 mock_report_sender_->GetAndResetNumberOfReportsSent());
254 } 221 }
255 222
256 } // namespace safe_browsing 223 } // namespace safe_browsing
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698