Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2164503006: Rename mojo_application GN templates to service* (Closed)

Created:
4 years, 5 months ago by Ben Goodger (Google)
Modified:
4 years, 5 months ago
CC:
Aaron Boodman, abarth-chromium, alokp+watch_chromium.org, ben+mojo_chromium.org, chromium-reviews, chromoting-reviews_chromium.org, darin (slow to review), darin-cc_chromium.org, dcheng, feature-media-reviews_chromium.org, jam, kalyank, piman+watch_chromium.org, qsr+mojo_chromium.org, rjkroege, sadrul, tfarina, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename mojo_application GN templates thusly: mojo_native_application -> service_package mojo_application_manifest -> service_manifest .mojo extension -> .library Committed: https://crrev.com/41cae6c40b350478500d0f7d82cde47b6e2bb8e3 Cr-Commit-Position: refs/heads/master@{#406777}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+512 lines, -940 lines) Patch
M ash/mus/BUILD.gn View 1 2 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download
M ash/sysui/BUILD.gn View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/app/BUILD.gn View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/app/mash/BUILD.gn View 4 chunks +5 lines, -5 lines 0 comments Download
M components/filesystem/BUILD.gn View 1 2 3 4 5 4 chunks +7 lines, -7 lines 0 comments Download
M components/font_service/BUILD.gn View 1 2 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download
M components/leveldb/BUILD.gn View 1 2 3 4 5 4 chunks +7 lines, -7 lines 0 comments Download
M content/content.gyp View 4 chunks +12 lines, -12 lines 0 comments Download
M content/public/app/BUILD.gn View 3 chunks +10 lines, -10 lines 0 comments Download
M mash/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M mash/app_driver/BUILD.gn View 1 2 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download
M mash/browser/BUILD.gn View 1 2 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download
M mash/catalog_viewer/BUILD.gn View 1 2 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download
M mash/example/views_examples/BUILD.gn View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
M mash/example/window_type_launcher/BUILD.gn View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M mash/init/BUILD.gn View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
M mash/login/BUILD.gn View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
M mash/quick_launch/BUILD.gn View 1 2 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download
M mash/screenlock/BUILD.gn View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
M mash/session/BUILD.gn View 1 2 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download
M mash/task_viewer/BUILD.gn View 1 2 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download
M mash/webtest/BUILD.gn View 1 2 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download
M media/mojo/services/BUILD.gn View 1 2 3 4 5 4 chunks +9 lines, -9 lines 0 comments Download
M mojo/public/c/system/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
D mojo/public/mojo_application.gni View 1 chunk +0 lines, -270 lines 0 comments Download
D mojo/public/mojo_application_manifest.gni View 1 chunk +0 lines, -139 lines 0 comments Download
D mojo/public/mojo_application_manifest.gypi View 1 chunk +0 lines, -56 lines 0 comments Download
D mojo/public/mojo_constants.gni View 1 chunk +0 lines, -8 lines 0 comments Download
D mojo/public/tools/manifest/manifest_collator.py View 1 chunk +0 lines, -104 lines 0 comments Download
M services/catalog/BUILD.gn View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M services/catalog/entry.h View 4 chunks +4 lines, -4 lines 0 comments Download
M services/catalog/entry.cc View 1 1 chunk +8 lines, -8 lines 0 comments Download
M services/catalog/reader.cc View 1 4 chunks +7 lines, -7 lines 0 comments Download
M services/catalog/store.h View 2 chunks +4 lines, -4 lines 0 comments Download
M services/catalog/store.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/navigation/BUILD.gn View 1 2 3 4 5 2 chunks +6 lines, -6 lines 0 comments Download
M services/shell/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M services/shell/background/tests/BUILD.gn View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
A + services/shell/public/constants.gni View 1 chunk +2 lines, -2 lines 0 comments Download
A services/shell/public/cpp/service.gni View 1 2 3 4 5 1 chunk +151 lines, -0 lines 0 comments Download
A + services/shell/public/service_manifest.gni View 7 chunks +32 lines, -32 lines 0 comments Download
A + services/shell/public/service_manifest.gypi View 1 2 3 2 chunks +9 lines, -9 lines 0 comments Download
A + services/shell/public/tools/manifest/manifest_collator.py View 1 5 chunks +22 lines, -22 lines 0 comments Download
M services/shell/runner/child/BUILD.gn View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M services/shell/runner/host/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M services/shell/runner/host/child_process_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M services/shell/runner/host/in_process_native_runner.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M services/shell/shell.gyp View 1 chunk +3 lines, -3 lines 0 comments Download
M services/shell/standalone/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/connect/BUILD.gn View 1 2 3 4 5 8 chunks +25 lines, -25 lines 0 comments Download
M services/shell/tests/lifecycle/BUILD.gn View 1 2 3 4 5 7 chunks +20 lines, -20 lines 0 comments Download
M services/shell/tests/shell/BUILD.gn View 1 2 3 4 5 4 chunks +8 lines, -8 lines 0 comments Download
M services/shell/tests/shutdown/BUILD.gn View 1 2 3 4 5 3 chunks +10 lines, -10 lines 0 comments Download
M services/tracing/BUILD.gn View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
M services/ui/BUILD.gn View 1 2 3 4 5 4 chunks +7 lines, -7 lines 0 comments Download
M services/ui/clipboard/BUILD.gn View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M services/ui/common/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M services/ui/demo/BUILD.gn View 1 2 3 4 5 2 chunks +7 lines, -7 lines 0 comments Download
M services/ui/gpu/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M services/ui/test_wm/BUILD.gn View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
M services/ui/ws/BUILD.gn View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M services/user/BUILD.gn View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M services/user/user.gyp View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/mus/BUILD.gn View 1 2 3 4 5 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 28 (19 generated)
Ben Goodger (Google)
4 years, 5 months ago (2016-07-20 23:04:14 UTC) #10
Ken Rockot(use gerrit already)
lgtm with the suggestion to change service_package -> service
4 years, 5 months ago (2016-07-20 23:19:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164503006/80001
4 years, 5 months ago (2016-07-20 23:57:05 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/99293) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, ...
4 years, 5 months ago (2016-07-21 00:02:36 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164503006/100001
4 years, 5 months ago (2016-07-21 00:07:13 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/263585)
4 years, 5 months ago (2016-07-21 02:32:53 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164503006/100001
4 years, 5 months ago (2016-07-21 05:01:36 UTC) #24
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 5 months ago (2016-07-21 06:08:30 UTC) #26
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 06:10:02 UTC) #28
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/41cae6c40b350478500d0f7d82cde47b6e2bb8e3
Cr-Commit-Position: refs/heads/master@{#406777}

Powered by Google App Engine
This is Rietveld 408576698