Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2164503005: [interpreter] Remove duped control scope in ForOfStatement. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Remove duped control scope in ForOfStatement. This removes a duplicate control scope. The visitor for ForOfStatement nodes in the AST uses VisitIterationBody which pushes a separate control scope. The number of control scopes will be off when we use them for tracking loop depths. R=rmcilroy@chromium.org Committed: https://crrev.com/57981a48bd6bc5dc9484045320884eeb3dc74774 Cr-Commit-Position: refs/heads/master@{#37930}

Patch Set 1 #

Patch Set 2 : Fix golden. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M src/interpreter/bytecode-generator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 1 5 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
Michael Starzinger
4 years, 5 months ago (2016-07-20 16:06:50 UTC) #6
rmcilroy
Good catch, thanks. LGTM.
4 years, 5 months ago (2016-07-20 16:20:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164503005/20001
4 years, 5 months ago (2016-07-21 08:27:49 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 09:11:54 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 09:13:54 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/57981a48bd6bc5dc9484045320884eeb3dc74774
Cr-Commit-Position: refs/heads/master@{#37930}

Powered by Google App Engine
This is Rietveld 408576698